Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsupported types should result in error tests failing on Safari and on Edge / Windows 10 #329

Closed
aninde opened this issue Apr 30, 2020 · 9 comments
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@aninde
Copy link
Contributor

aninde commented Apr 30, 2020

Description

After running the tests runner on does not pass 1 test on

  • Safari v.10.15 / macOs Catalina 10.15.4 (latest)
  • QQ Browser Lite v.1.2.9 / macOs Catalina 10.15.4
  • Safari / iPad osX 13.3.1.
  • Edge v.44.17763.831.0 / Windows 10
  • Sogou v.8.6.3.32395 / Windows 10

Failed test:
unsupported types should result in error > should give parsing error # 11
Expected function to throw an exception with message 'Unable to parse value: "BigInt(9007199254740991)"', but it threw an exception with message 'Can't find variable: BigInt'.

the test also fails if it is released independently.
Screenshot 2020-04-30 at 15 38 39

I have a problem reproducing it on iPhone 6s, probably by releasing a new version of iPhone SE. I will try to reproduce this using BrowserStack

@aninde aninde added the Bug Something isn't working label Apr 30, 2020
@aninde aninde changed the title unsupported types should result in error tests failing on Safari on macOs Catalina and iOS unsupported types should result in error tests failing on Safari on macOs Catalina and iOS and on Edge 44.177... / Windows 10 Apr 30, 2020
@aninde aninde changed the title unsupported types should result in error tests failing on Safari on macOs Catalina and iOS and on Edge 44.177... / Windows 10 unsupported types should result in error tests failing on Safari and on Edge / Windows 10 Apr 30, 2020
@aninde
Copy link
Contributor Author

aninde commented Apr 30, 2020

On newer ✅Edge Chromium (Edge Devs) all tests pass on Windows 10.

@wojciechczerniak
Copy link
Contributor

BigInt is not always implemented. We should make the support optional, and check if it exists.

Maybe it's in the test only but we need to verify the production code @izulin

@aninde
Copy link
Contributor Author

aninde commented May 4, 2020

The same bug appears in the browser Sogou v. 8.6.3.32395 / Windows 10. Sogou can only be installed on Windows. No tests were done on MacOS.

image

@aninde
Copy link
Contributor Author

aninde commented May 4, 2020

I have updated the list in the main description because the error also occurs on QQ browser / MacOs.

@izulin izulin assigned izulin and unassigned bardek8 May 4, 2020
@izulin izulin mentioned this issue May 4, 2020
7 tasks
@aninde
Copy link
Contributor Author

aninde commented May 4, 2020

unsupported types should result in error > should give parsing error # 11

it('should give parsing error #11', () => {

@izulin
Copy link
Collaborator

izulin commented May 4, 2020

unsupported types should result in error > should give parsing error # 11

it('should give parsing error #11', () => {

Thanks!

@aninde
Copy link
Contributor Author

aninde commented May 4, 2020

BigInt is not supported by Internet Explorer and Safari :( the rest of the browsers listed above can be based on the IE-engine, so I wouldn't count on having support for this, so this is not our bug.
image
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt

@wojciechczerniak
Copy link
Contributor

@aninde Should be fixed in #338. Can you re-test develop for this issue?

@aninde
Copy link
Contributor Author

aninde commented May 6, 2020

I checked on all browsers mentioned above. Is fixed.

@aninde aninde closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants