Doesn't work correctly with newer node.js versions

[wojciechczerniak]

Description

Set the minimal required node.js version in package.json. The requirement comes from GPU.js that requires node >=10.0.0.

[aninde]

Dependencies do not install correctly and build failed when node v. 12.13.0 is used.

1 error generated.
make[1]: *** [Release/obj.target/webgl/src/bindings.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/ndemytruk/Desktop/work/hyper/hyperformula/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:210:5)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Darwin 19.0.0
gyp ERR! command "/Users/ndemytruk/.nvm/versions/node/v12.13.0/bin/node" "/Users/ndemytruk/Desktop/work/hyper/hyperformula/node_modules/gl/node_modules/.bin/node-gyp" "rebuild"
gyp ERR! cwd /Users/ndemytruk/Desktop/work/hyper/hyperformula/node_modules/gl
gyp ERR! node -v v12.13.0
gyp ERR! node-gyp -v v3.8.0

make: *** [setup] Error 1

Build is succesful while using node v11.15.0 (npm v6.7.0).

[wojciechczerniak]

Wasn't working for me in v13 either.

[swistak35]

12.13.0 works for me (with cleaning node_modules before npm install), make check afterwards works too
13.9.0 indeed fails, but only because some packages missing on my Ubuntu, found solution here: stackgl/headless-gl#71 (comment) -- installing these packages helped. make check passes.

[wojciechczerniak]

I can confirm that the latest develop works with
v13.7 v13.0 v12.16 v11.15

Mac OS X 10.15, no additional packages needed

[aninde]

I can confirm that branch conformance and develop work on mac OS X 10.15.2 with the latest node 13.9

[wojciechczerniak]

Thx

[aninde]

I tried to build HyperFormula on Windows 10 and I failed on node 13.9 and node 10.0.
Can somebody who knows Windows more than me, can try?

I used nvm-windows. After preparing environment (yarn, nvm-windows, node10.0.0 and node13.9.0 installation) I tried to build HF by npm i in repo directory.
Build crashes with the request for installation of prebuild-install. I installed that via npm, and tried npm i once again but it didn't change anything.

I understand that I need to install Python, but this should not happen during npm i?

Here's log with errors rom failder build on Windows 10
2020-03-02T15_29_53_193Z-debug.log

[aninde]

I was able to build Hyperformula and run tests on Windows 10 with node 13.9.0 and node 10.14.0, both installed by nvm-windows.
@scarletfog this can be useful for documentation.

Running HyperFormula on Windows 10 required installation of :

• python
  • Install launcher for all users
  • Add Python 3.8. to PATH
  • Disable path length limit
• nvm-windows
• node 13.9.0 using nvm-windows
  • $ nvm install node13.9.0 //no spaces is not a mistake
  • $ nvm use node13.9.0
• node-gyp as superUser via PowerShell
  • Installation based on https://github.com/nodejs/node-gyp#option-1
• yarn
  • https://classic.yarnpkg.com/en/docs/install/#windows-stable via installer

There is no Unix make on Windows, so instead of make setup, I enterer yarn install directly.
For testing yarn jest