Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redux example doesn't work with mergeCells #7555

Open
AMBudnik opened this issue Dec 13, 2019 · 3 comments
Open

Redux example doesn't work with mergeCells #7555

AMBudnik opened this issue Dec 13, 2019 · 3 comments
Labels
bug React Issues regarding the @handsontable/react wrapper. Reported

Comments

@AMBudnik
Copy link
Contributor

Description

As mentioned in our forum https://forum.handsontable.com/t/react-redux-render-with-mergecells-prop-triggers-beforechange-callback-call/3928 once we add mergeCells to the official Redux example we end up with an infinite loop.

Steps to reproduce

  1. Do nothing, just check the console

Demo

https://handsontable.com/docs/7.2.2/frameworks-wrapper-for-react-redux-example.html official example
https://jsfiddle.net/AMBudnik/pftvn5qm/ the same code with mergeCells line 11

Your environment

  • React wrapper version: 3.1.0
  • Handsontable version: 7.2.2
  • Browser Name and version: Chrome 78
  • Operating System: Windows 10
@rbarato
Copy link

rbarato commented Dec 19, 2019

Hi, this happens regardless the react wrapper: https://jsfiddle.net/rbarato/9yv0om48/3/

And it looks like the changes keep growing exponentially, the more merged cells I have, the more will be added to the array. In my case I have to loop thought the changes so I can process a very specific scenario and we're having issues with a sheet that has 79 areas merged and is generating an 11k changes array which crashes the sheet.

@AMBudnik
Copy link
Contributor Author

So this is not the same case (there's no infinite loop) but it makes the example unusable when we have many merged cells. We need to check all the scenarios while fixing.
Thank you for the feedback @rbarato

@mrpiotr-dev
Copy link
Contributor

Hi @rbarato,
We merged wrapper for React into our main repository, handsontable/handsontable. Now library and wrapper are available in monorepo.
We also transfer all issues into one common issue board, where you can follow work progress and request issues.

@mrpiotr-dev mrpiotr-dev transferred this issue from handsontable/react-handsontable Feb 18, 2021
@mrpiotr-dev mrpiotr-dev added React Issues regarding the @handsontable/react wrapper. bug labels Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug React Issues regarding the @handsontable/react wrapper. Reported
Projects
None yet
Development

No branches or pull requests

4 participants