Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Hindi language #136

Merged
merged 1 commit into from Nov 1, 2020

Conversation

Prasanta-Hembram
Copy link
Contributor

@Prasanta-Hembram Prasanta-Hembram commented Oct 31, 2020

I have translated Easy Diary in Hindi Language. I love to add one additional language Santali but it uses a little new script Ol Chiki and a non ASOP language which cannot be set from device settings but it is widely supported in Android. So i request you to please add in-app language selection with the application like #59(Multilingual UI), so that i can help add one additional language for this very useful application.

Thanks

@hanjoongcho
Copy link
Owner

@Prasanta-Hembram
First of all, thank you for participating in the Easy Diary Project translation.
I have a few questions.
Q1> The language you requested for PR is Hindi (hi_IN), one of the official languages of India, right?
Q2> And what you want additionally is the following content?
Added ability to set Santali language using Ol Chiki characters (Similar to the content of issue #59)
Q3> What is'non ASOP language'?

@Prasanta-Hembram
Copy link
Contributor Author

Prasanta-Hembram commented Oct 31, 2020

Q1> The language you requested for PR is Hindi (hi_IN), one of the official languages of India, right?
Q2> And what you want additionally is the following content?
Added ability to set Santali language using Ol Chiki characters (Similar to the content of issue #59)
Q3> What is'non AOSP language'?
Sorry for not clarifying :-|>

1- Yes, correct hi_HI is official language of India and this pull is for this only, rest are just my doubts.
2- Yes, Santali is also officially recognized language of India which is now written in Ol Chiki script and i am a native speaker of Santali language. It you agree then i will also proceed for translation in Santali language.
2. Yes as shown in the figure of drop down language selection feature in #59. Actually your app supports language change from device settings only. Till now no android ROM supports this language change from System language selection, but their is reading support and people can write as well with Ol Chiki script(Support in Gboard). This script is used to write articles in Santali Wikipedia(sat.wikipedia.org/).
3. Sorry for not clearing it, by AOSP support languages i mean by default not all android ROM supports Santali language(code-sat), infact it is never transalated or not yet added as a language selection in any ROM. So we cannot change the language of the application to Santali if i translate it then is of no use, so i was asking of any sign of adding that dropdown language selection feature within the application. If so then may i proceed to translate it in Santali language?

update: edited ASOP as AOSP

@Prasanta-Hembram
Copy link
Contributor Author

Prasanta-Hembram commented Oct 31, 2020

Also, i clarify that Santali was used to be written in roman, devnagri script but after Pandit Raghunath Murmu invented Ol Chiki script, people widely use this script. Hindi is written in devnagri script only and is supported in almost all ROM, ex. It can be selected from device settings. The pull request i made is for Hindi language (Official language of India) only, i know both language very well. For Santali language if you agree i can also contribute. I hope i am clear:-).

Also i thank you for creating very nice ad free diary application. Please keep it adfree :-)

@hanjoongcho
Copy link
Owner

@Prasanta-Hembram
I understand what you want.
I still have one question.
Maybe ASOP is a typo of AOSP (Android Open Source Project)?
If it's not a typo, can you tell us the full name of ASOP?

@Prasanta-Hembram
Copy link
Contributor Author

Many apology @hanjoongcho above ASOP is AOSP.

@hanjoongcho
Copy link
Owner

@Prasanta-Hembram
The question was resolved.

The PR you requested will be merged immediately.
I'll add features if possible after technical review to see if it is possible to set and use languages other than the official Android language in the OS setting.

@hanjoongcho hanjoongcho merged commit 12d3097 into hanjoongcho:master Nov 1, 2020
@hanjoongcho
Copy link
Owner

@Prasanta-Hembram
Please note that the part where the LIne Break character was incorrectly entered was corrected :)
72d172d

@Prasanta-Hembram
Copy link
Contributor Author

I'll add features if possible after technical review to see if it is possible

Thanks @hanjoongcho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants