Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion in F-Droid #17

Closed
Poussinou opened this issue May 15, 2018 · 9 comments
Closed

Inclusion in F-Droid #17

Poussinou opened this issue May 15, 2018 · 9 comments
Assignees

Comments

@Poussinou
Copy link

Hi,

Since this app is Apache v2 licensed, are you considering the fact to add it to F-Droid? There is a strong community behind, that do not use Google Play nor anything else, except F-Droid.

You can find some documentation here.

Otherwise, if you don't want to work on the inclusion of this app by yourself, would it be ok for you if someone else do it for you?

@hanjoongcho
Copy link
Owner

Thank you for your feedback.
Let's look at deploying applications using F-Droid.
If you need help, we will ask for your help =)

@hanjoongcho hanjoongcho self-assigned this May 15, 2018
@hanjoongcho hanjoongcho added this to To Do in easydiary v1.4 via automation May 15, 2018
@Poussinou
Copy link
Author

You will probably have to write a new gradle build flavor since com.google.android.gms:play-services-drive:11.8.0 is probably not FLOSS. It's not a problem if this functionality doesn't work in the F-Droid build, the users are used to that kind of things, and there is no way to circumvent it.

@IzzySoft
Copy link

@hanjoongcho

implementation "com.google.android.gms:play-services-drive:$versions.gms"
implementation "com.google.android.gms:play-services-auth:$versions.gms"

are show-stoppers. Can you provide a FOSS build-flavor that comes without those? Else I'm afraid F-Droid inclusion might not be possible.

@hanjoongcho
Copy link
Owner

We added a flavor setting to make it buildable, except for the gms library.

@IzzySoft
Copy link

Thanks @hanjoongcho! Just reported that at our end, so hopefully it will be picked up soon.

@IzzySoft
Copy link

@hanjoongcho now we have a different problem: the icons used require an account to be downloaded. No chance that we can integrate that with our build process (see here). Is there an alternative?

@hanjoongcho
Copy link
Owner

@IzzySoft
Added flavor settings, including five icons to replace Flatinon weather icons. =)

@IzzySoft
Copy link

IzzySoft commented Feb 1, 2019

Wow, that was fast! Thanks a lot! I've reported this on our end and asked our "integrator" to give it another try.

@Rudloff
Copy link

Rudloff commented Feb 1, 2019

I confirm it now builds correctly, thanks!

easydiary v1.4 automation moved this from To Do to Done Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants