Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whole repo #21

Open
ky1ejs opened this issue Sep 23, 2016 · 2 comments
Open

Check whole repo #21

ky1ejs opened this issue Sep 23, 2016 · 2 comments
Milestone

Comments

@ky1ejs
Copy link

ky1ejs commented Sep 23, 2016

Would you be open to the idea of making a command/method for checking the whole repo/project for TODOs? At the moment only the diff is checked, which poses two issues:

  • If you're adding this to an existing project, you'll never be warned about all the TODOs that could be out there
  • If a TODO is ignored for a given PR (maybe put aside for whatever reason), then it will not be brought up again
@hanneskaeufler
Copy link
Owner

hanneskaeufler commented Sep 24, 2016

I definately want to tackle the second issue. Thinking of something like

todoist.ignore_existing = false
todoist.warn_for_todos

which would then report existing TODOs in files that were touched.
Not sure about searching the entire repo, to me danger is kind of scoped to the changes of a PR.

@ky1ejs
Copy link
Author

ky1ejs commented Sep 26, 2016

Sounds good 👍

@hanneskaeufler hanneskaeufler added this to the v1.3.0 milestone Dec 20, 2016
@hanneskaeufler hanneskaeufler modified the milestones: v1.3.0, v1.4.0 Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants