Make filenames clickable

[sobolevn]

Hi, @hanneskaeufler! Thanks for your awesome plugin.
We are using it inside our review pipeline with great success: https://github.com/wemake-services/kira-review

But, I would like to suggest adding a very useful feature: clickable filenames and lines.
When I review current TODOs I have to go inside the code manually, find the correct line, and then go back again.

I would like to suggest something like this.

1. Line #N becomes a clickable link

2. When you click it, browser will open a new tab with the correct branch (the one you review), correct file and line number:

As far as I know we can use gitlab.html_link(item) to make full path from filename. It will require some changes to also accept lineno, I guess.

What do you think?
I can help you with that, but I am not a Ruby developer.

[hanneskaeufler]

Hi @sobolevn, I am glad you find it useful! That's a very good suggestion you make. I would be happy to enable the plugin do something like that. I might look into it at some point, but please don't hold your breath on me ever implementing it.

I am super happy to help you by reviewing a PR or answering questions though, so please feel free and try to implement it yourself. This is the spot where we construct the todo entries:
https://github.com/hanneskaeufler/danger-todoist/blob/master/lib/todoist/plugin.rb#L99. The Todo class has a file property https://github.com/hanneskaeufler/danger-todoist/blob/master/lib/todoist/todo.rb#L2, so as you said adding a gitlab.html or github.html should not be too hard to achieve. As for adding a line marker, yeah, we could probably make a contribution to danger to allow passing the #LXX to the html method, or go the hacky route and just slap it onto the link ourselves.

Again, thanks for the suggestion!

[sobolevn]

@hanneskaeufler thanks! I will try my best.