All binaries built by CD workflow are labeled as release binaries #883
Labels
good first issue
Good for newcomers
topic: build
Anything relating to the build system.
type: bug
Something isn't working
As of #868, we now have a
--version
argument that displays the version, and makes a distinction between release and development versions. Unfortunately all binaries built by the CD workflow are labeled as release binaries for the purpose of the--version
flag. This leads those binaries that aren't promoted to release binaries to display a wrong version.The way it works, is that on every push to
main
, the CD workflow is started, and builds binaries:https://github.com/hannobraun/Fornjot/blob/016d5d2b2ff2dd33888c1b25d38d47c1f2c4749d/.github/workflows/cd.yml#L23-L77
The flag that marks the binaries as official release binaries is wrongly set for that whole workflow:
https://github.com/hannobraun/Fornjot/blob/016d5d2b2ff2dd33888c1b25d38d47c1f2c4749d/.github/workflows/cd.yml#L14-L16
After all binaries are built, the release job starts, and will publish a release (using those binaries), if that's what is supposed to happen. Whether it's supposed to happen, is determined by the
Operator | Deduce
step:https://github.com/hannobraun/Fornjot/blob/016d5d2b2ff2dd33888c1b25d38d47c1f2c4749d/.github/workflows/cd.yml#L101-L109
At this point, the binaries have already been built.
I see two ways to address this:
Operator | Deduce
step to a separate job that runs before the binaries are built. Only setFJ_OFFICIAL_RELEASE
, if it detects that a release should happen.I think I'd prefer solution 1, but I'd accept solution 2.
Labeling as https://github.com/hannobraun/Fornjot/labels/good%20first%20issue, since this only requires knowledge of GitHub Actions to address, not any deeper understanding of Fornjot in particular.
The text was updated successfully, but these errors were encountered: