Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print timestamp with each status update #971

Closed
hannobraun opened this issue Aug 22, 2022 · 1 comment · Fixed by #1256
Closed

Print timestamp with each status update #971

hannobraun opened this issue Aug 22, 2022 · 1 comment · Fixed by #1256
Labels
good first issue Good for newcomers type: feature New features and improvements to existing features

Comments

@hannobraun
Copy link
Owner

The Fornjot app has recently started displaying status updates, indicating that a model has been reloaded, or that an error occurred while trying to do just that.

If the model has previously been loaded successfully for a few times, it can be hard to judge whether a recent change has been registered. Unless it causes an error, the status update will look identical to the previous ones that were already there.

It would be great, if status updates showed a timestamp. Ideally, it would show how long ago that status update was, but as an initial implementation, just showing the time will be more than enough.

@hannobraun hannobraun added type: feature New features and improvements to existing features topic: ui labels Aug 22, 2022
@hannobraun hannobraun added this to the Basic Usability milestone Aug 22, 2022
@hannobraun
Copy link
Owner Author

hannobraun commented Sep 26, 2022

The status messages are controlled by the StatusReport struct in fj-interop. Adding the timestamp should be a relatively straight-forward addition to the update_status method.

Labeling https://github.com/hannobraun/Fornjot/labels/good%20first%20issue, since this should be a fairly small and isolated change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: feature New features and improvements to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant