Simplify topology types #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Vertex` is going to lose all `Copy`, which this function relies on.
I'm working on elimianting the redundancy of the topological data, which requires the respective types to have references or handles to other types, instead of owning them. Those handles won't be `Copy`, which means the topological types won't be able to be that either.
See previous commit about un-deriving `Copy` from `Edge`.
Its presence is making the changes I'm working on more complicated. Removing it makes the tests that use it only a little bit more complicated, which I think is an okay trade-off.
It is redundant.
This is an issue I went back and forth on a few time already. It seems less robust, as nothing prevents these vertices from having nothing to do at all with the curve they are supposed to be on, and I can think of reasons why it can't stay this way long-term. But the facts are, storing edge vertices in 1D isn't necessary right now, makes things more complicated, and makes my ongoing work right now a million times more difficult. I'm pretty sure I'll want to revert this decision again some time in the future, but for now, this is the right call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify some topology types, mostly
VertexandEdge. This came out of my work on #280, and these simplifications will make addressing that issue much easier.