Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add remix style routing example #169

Merged
merged 3 commits into from
Feb 18, 2022
Merged

feat: add remix style routing example #169

merged 3 commits into from
Feb 18, 2022

Conversation

lxy-yz
Copy link
Contributor

@lxy-yz lxy-yz commented Feb 12, 2022

Following https://remix.run/docs/en/v1/api/conventions#route-file-conventions added remix style routes that supports:

  • basic routes
  • layout routes
  • dynamic routes
  • catch all routes
  • pathless routes
  • routes with escaping characters

@hannoeru
Copy link
Owner

@lxy-yz Thanks for this PR, can you fix tests and lint errors?

@hannoeru
Copy link
Owner

LGTM, Can you also add document to README.md?

N0tExisting
N0tExisting reviewed Feb 14, 2022
View reviewed changes
src/types.ts Outdated Show resolved Hide resolved
@hannoeru
Copy link
Owner

@lxy-yz looks like lock file is broken, can you fix that?

@lxy-yz
Copy link
Contributor Author

lxy-yz commented Feb 15, 2022 •
edited

@lxy-yz looks like lock file is broken, can you fix that?

@hannoeru I've tried to reproduce it locally but without luck. The error message in CI ERR_PNPM_LOCKFILE_MISSING_DEPENDENCY  Broken lockfile: no entry for '/@vitejs/plugin-react/1.1.4' in pnpm-lock.yaml doesn't align with what I was seeing on local, suggestions?

@N0tExisting
Copy link

@lxy-yz as can be seen here you need to run a install.

It is also mentioned on the line above, that This issue is probably caused by a badly resolved merge conflict. (might have something to do with force-pushing?)

@lxy-yz
Copy link
Contributor Author

lxy-yz commented Feb 15, 2022 •
edited

@lxy-yz as can be seen here you need to run a install.

It is also mentioned on the line above, that This issue is probably caused by a badly resolved merge conflict. (might have something to do with force-pushing?)

@N0tExisting
Thanks for taking a look. I've tried what the error message suggests. And lock file seems to look fine on local machine (with '/@vitejs/plugin-react/1.1.4' in pnpm-lock.yaml)

This issue is probably caused by a badly resolved merge conflict.

I didn't resolve any merge conflicts.

@hannoeru
Copy link
Owner

@lxy-yz I think run pnpm update can fix that.

@hannoeru hannoeru merged commit 6dfd002 into hannoeru:main Feb 18, 2022
ckangwen pushed a commit to charrue/vite-plugin-pages that referenced this pull request Jan 24, 2023
@lxy-yz
feat: add remix style routing (hannoeru#169)
5df405a 
* feat: add remix style routing example

* chore!: renamed nuxtStyle to routeStyle to support different naming conventions

* fix: deps issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannoeru hannoeru hannoeru left review comments

@N0tExisting N0tExisting N0tExisting left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lxy-yz @hannoeru @N0tExisting