New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
final fixes #11
final fixes #11
Conversation
Thanks, great 馃憤馃徎 Will look at it soon. Do you want me to put your name or GitHub handle in the board? |
Sure, "Nikita Lita" will be fine. |
@nikitalita The Diff Pair traces on the top and bottom PHY look different. Are you sure you adjusted them both? |
Yes, the bottom one as it looks. I will adjust the top one too. Ok, did it. WIll commit soon 0.09mm gap is hard on the edge of JLCPCB manufacturing capability. Let's hope it turns out right. |
@nikitalita I am a bit surprised, though, that you didn't have to input the dielectric constant in this calculator. |
Urgh, I did only apply it to the bottom one, and I forgot to length match the top one. I just fixed this and adjusted the values of the main run according to the new calc above, PR incoming. |
@nikitalita please pull first, I already adjusted the top one. |
I did, the top one had the main run adjusted but not the back part. |
I added back the custom rules and changed them so that:
The custom rules catch stuff that the global rules don't, but fortunately, we didn't have anything to fix here.
I also length matched the D- and D+ lines by making D- and D+ both use vias to cross each other; I also adjusted the spacking and width of the tracks of the main run based on this calculation from eeweb:
With this, I think we're finally finished with this revision 馃コ