Possible locking issues (e.g., deadlocks)

[ryancaicse]

Hi, it seems lock l_conf is not released before Line 1234.

rt-n56u/trunk/user/firefly/mt-daapd-svn/src/conf.c

Lines 1231 to 1238 in c9c3cec

	util_mutex_lock(l_conf);
	if(!conf_main_file)
	return FALSE;
	retval = !access(conf_main_file,W_OK);
	util_mutex_unlock(l_conf);

[ryancaicse]

it seems lock ltc_ecc_fp_lock is not released before Line 1436.

rt-n56u/trunk/user/dropbear/dropbear-202X.XX/libtomcrypt/src/math/fp/ltc_ecc_fp_mulmod.c

Lines 1415 to 1436 in c9c3cec

	LTC_MUTEX_LOCK(&ltc_ecc_fp_lock);
	/*
	* build the list;
	Cache DEFINITIONS ::=
	BEGIN
	CacheDump ::= SEQUENCE {
	numEntries SHORTINTEGER,
	maxEntries SHORTINTEGER,
	numLUT SHORTINTEGER,
	cache SEQUENCE OF INTEGER
	}
	END
	*
	*/
	/*
	* The cache itself is a point (3 INTEGERS),
	* the LUT as pairs of INTEGERS (2 * 1<<FP_LUT),
	* and the mu INTEGER
	*/
	cache_entry = XCALLOC(FP_ENTRIES*(2*(1U<<FP_LUT)+4)+3, sizeof(ltc_asn1_list));
	if (cache_entry == NULL)
	return CRYPT_MEM;

[ryancaicse]

lock s->mutex is not released before Line 608.

rt-n56u/trunk/libs/libav/ffmpeg-0.11.x/libavformat/udp.c

Lines 576 to 608 in c9c3cec

	pthread_mutex_lock(&s->mutex);
	do {
	avail = av_fifo_size(s->fifo);
	if (avail) { // >=size) {
	uint8_t tmp[4];
	av_fifo_generic_read(s->fifo, tmp, 4, NULL);
	avail= AV_RL32(tmp);
	if(avail > size){
	av_log(h, AV_LOG_WARNING, "Part of datagram lost due to insufficient buffer size\n");
	avail= size;
	}
	av_fifo_generic_read(s->fifo, buf, avail, NULL);
	av_fifo_drain(s->fifo, AV_RL32(tmp) - avail);
	pthread_mutex_unlock(&s->mutex);
	return avail;
	} else if(s->circular_buffer_error){
	int err = s->circular_buffer_error;
	pthread_mutex_unlock(&s->mutex);
	return err;
	} else if(nonblock) {
	pthread_mutex_unlock(&s->mutex);
	return AVERROR(EAGAIN);
	}
	else {
	/* FIXME: using the monotonic clock would be better,
	but it does not exist on all supported platforms. */
	int64_t t = av_gettime() + 100000;
	struct timespec tv = { .tv_sec = t / 1000000,
	.tv_nsec = (t % 1000000) * 1000 };
	if (pthread_cond_timedwait(&s->cond, &s->mutex, &tv) < 0)
	return AVERROR(errno == ETIMEDOUT ? EAGAIN : errno);

[ryancaicse]

@andy-padavan Could you take a look? thanks