Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion thread #86

Open
ghost opened this issue Apr 17, 2016 · 37 comments
Open

Discussion thread #86

ghost opened this issue Apr 17, 2016 · 37 comments
Labels

Comments

@ghost
Copy link

ghost commented Apr 17, 2016

I improved the pull-requesting rule as follows:

  1. You have to pull-request unless you created that branch and no other people have yet commit-ed on the branch.
  2. Minor bug fix pull requests may be merged automatically, however others have the right to revert it.
  3. Major bug fixes and small feature addition/deletion takes 1 day to merge.
  4. Remarkable feature additions/edits takes 2 days to merge.
  5. Reformatting and changing code structure requires another collaborator to review it. This (may) take up to a limit of 1 1/2 weeks (11 days)
@hanyuone
Copy link
Owner

We can leave this until later - we'll have the two-day rule for now (leave this for more people).

@ghost
Copy link
Author

ghost commented Apr 18, 2016

okay.

@ghost ghost closed this as completed Apr 18, 2016
@ghost ghost reopened this Apr 18, 2016
@ghost ghost changed the title On pull-requesting thing Discussion thread May 5, 2016
@ghost
Copy link
Author

ghost commented May 5, 2016

CHANGE: This thread will now be open for any questions (or comments.)

@hanyuone
Copy link
Owner

hanyuone commented May 6, 2016

Ah, cool cool. So we can get rid of the other thread? I'll put a link to it.

Repository owner locked and limited conversation to collaborators May 6, 2016
@ghost
Copy link
Author

ghost commented May 7, 2016

yeah...(?)

@hanyuone
Copy link
Owner

hanyuone commented May 7, 2016

#26.

@ghost
Copy link
Author

ghost commented May 7, 2016

I was wondering if we should make a 'levelling' system and a progress bar for that in the game. Would it be too complex?

Also, if anyone has any ideas, they can post it on this thread.
@DerpfacePython DerpfacePython added enhancement py3version py2version labels on 5 Jan
@qlstudio
Collaborator
qlstudio commented on 6 Jan

Talking about this? Thanks for feedback!

http://www.tkdocs.com/tutorial/morewidgets.html#progressbar
@DerpfacePython
Owner
DerpfacePython commented on 6 Jan

YES! That is exactly what I'm looking for!!!!
But how are we going to add it?
@qlstudio
Collaborator
qlstudio commented on 6 Jan

Well, we'd have to determine a "money goal" like $5q and tell the user how close he/she is to getting there (whoa.... 5q is hours away)
@DerpfacePython
Owner
DerpfacePython commented on 7 Jan

Wait... you can send errors through Python? What...???

As well as that, when should we make V1.0? When Cyber_Shadow finishes his visual overhaul?
Also, what is API?
@qlstudio
Collaborator
qlstudio commented on 7 Jan

Yeah... 1.0 needs to be something completely different from what we have so far...
By the way, shouldn't we add a Progressbar for the auto-money, like the progressbar shows when you would get your next MPS amount?

API stands for application program interface. I don't really no what it is... how did you get that question? More here: http://www.webopedia.com/TERM/A/API.html

Sending issues is quite easy, you just need the PyGithub extension . See more here: https://github.com/PyGithub/PyGithub
@DerpfacePython
Owner
DerpfacePython commented on 7 Jan

But all buildings generate money every 0.1 seconds (100 milliseconds - I have no idea why I put this here, but eh).

I got API from the semantic versioning thing, and it says to update to a major version when API can't be backtracked (or something like that, I didn't really understand it either).
@DerpfacePython
Owner
DerpfacePython commented on 8 Jan

My original idea for the progress bar was to make it a levelling system, or something like that.
@Cyber-Shadow
Collaborator
Cyber-Shadow commented on 11 Jan

The progress bar is a good idea, i suggest basing it on achievements (Yes we can have achievements) .
I also like the idea of a leveling system.
@DerpfacePython DerpfacePython locked and limited conversation to collaborators on 20 Jan
@DerpfacePython
Owner
DerpfacePython commented on 20 Jan

Continuing on the idea of the progress bar thing, I was thinking we could get two separate levelling systems - a "Clicking" one, and an "Idle" one. We can also have "level-up" upgrades.

"Clicking" levels - simple and efficient, basically it you level up based on how many clicks you do. The "level-up" upgrades would be "Main Button" based.
"Idle" levels - not as simple; you level up based on your lifetime currency (we really need to implement a prestige system - 0.7.0, perhaps?). "Level-up" upgrades will be building-based.

So, @qlstudio, @Cyber-Shadow, what do you guys think?
@DerpfacePython
Owner
DerpfacePython commented on 23 Jan

OK everyone - I need ideas for the level-up's... STAT.

EDIT: Wow... I love everyone's idea of "STAT". It's almost been two weeks and nobody's responded.
@qlstudio
Collaborator
qlstudio commented on 9 Feb

    progressbar telling how close you are to some "money goal" like 5q
    progressbar telling the total click/time ratio
    progressbar telling how much more clicks until a level-up
        the amount of clicks needed for a click level up should be based by 2^Prev level-ups * 25

@DerpfacePython @Cyber-Shadow - RSVP!!!!!!!

EDIT: LATeX Doesnt work ????
@DerpfacePython
Owner
DerpfacePython commented on 10 Feb

LaTeX? What do you need to use LaTeX for?

Also, if we include those progressbars, @qlstudio, I'm not sure if it'll be too many progressbars (5's WAY too much). I was thinking of making the achievements secret.
@qlstudio
Collaborator
qlstudio commented on 10 Feb

We can create a progressbar menu? Like what we did with the upgrades?

+, what were @DerpfacePython @Cyber-Shadow WHERE have you been these days? So long!
@qlstudio qlstudio added help wanted future labels on 10 Feb
@qlstudio
Collaborator
qlstudio commented on 13 Feb

Like we could create a big button right of Upgrades. When we click it it would reveal a huge chart of progressbars (Or, to make things simple, just place the chart next to the button - eh, it's actually difficult to keep track of how much % should be displayed when the chart is hidden) + @DerpfacePython @Cyber-Shadow @joshgit There needs new ideas STAT.
@DerpfacePython
Owner
DerpfacePython commented on 14 Feb

Sure, but there's still TOO MANY PROGRESSBARS. We could have a different menu for achievements, but the two main "levelling" systems should be on the main screen.
@qlstudio
Collaborator
qlstudio commented on 27 Mar

My idea was one "clicking" progressbar to show the (money earned from clicks) to (money total earned) ratio. Same thing for "idle". So they'd go forward AND backward?
@DerpfacePython
Owner
DerpfacePython commented on 2 Apr

Maybe... but later on in the game, the "idle" progressbar would always be full, and the "clicking" progress bar would be empty. I was thinking more along the lines of upgrades and stuff (i.e. levelling and stuff, see above for more detail).

Also, is there a way to move the images to a separate folder and still get them?
@qlstudio
Collaborator
qlstudio commented on 3 Apr

    Also, is there a way to move the images to a separate folder and still get them?

Of course, just specify the folder like "images/gold.gif"
@DerpfacePython
Owner
DerpfacePython commented on 3 Apr

Oh... because I've drawn some images to go with the individual buildings. Thanks.
@qlstudio
Collaborator
qlstudio commented 7 days ago

ANY OTHER QUESTIONS??? WHEN ARE WE GOING TO IMPLEMENT THIS???
@DerpfacePython
Owner
DerpfacePython commented 7 days ago

Uhhhh... we can implement this later... we'll work on the progress bar stuff first.
@qlstudio
Collaborator
qlstudio commented 7 days ago

That's what I'm talking about!
@DerpfacePython
Owner
DerpfacePython commented 7 days ago • edited

Oh... eh heh heh...

We can add this to the future branch, it's for V0.8.0. So yeah, we're implementing this now now, but the version will be out sometime in the (hopefully) near future. Probably need to wait for the sorting file stuff first, though.
@qlstudio
Collaborator
qlstudio commented 7 days ago

Yeah. (It's Sydney time 11:00 PM - you're still awake?)
@joshgit
Collaborator
joshgit commented 6 days ago

Is there an IRC channel for this project? I forget. If not, please make one on freenode. I'll lurk in #waystonotmakemoney unless someone else has a better idea.
@DerpfacePython
Owner
DerpfacePython commented 6 days ago

Maybe we can have a Skype group. Do you people have Skype?
@joshgit
Collaborator
joshgit commented 6 days ago

Can I just merge my pull request? We need take these broken wings and learn to fly again.
@DerpfacePython
Owner
DerpfacePython commented 6 days ago • edited

Well, sure. It looks pretty good. I'll ask @qlstudio to test out stuff later, and we can fix any issues still remaining if there is any.
@qlstudio
Collaborator
qlstudio commented 6 days ago

I have Skype, but due to the time zone difference...
@DerpfacePython
Owner
DerpfacePython commented 5 days ago

Yeah.

@ghost
Copy link
Author

ghost commented May 7, 2016

if anyone was looking for that.

@hanyuone
Copy link
Owner

hanyuone commented May 7, 2016

Whoa. Whoa whoa whoa. That is beautiful, @QLStudio.

Thanks.

@ghost
Copy link
Author

ghost commented May 7, 2016

@joshgit @DerpfacePython My PyClicker IRC availability is as follows:

Day Time
Mon 6:30 PM ~ 6:45 PM
Tues -
Wed 6:30 PM ~ 6:45 PM
Thur -
Fri 6:00 PM ~ 7:00 PM
Sat 7:00 AM ~ 8:00 AM / 11:00 AM ~ 12:00 PM / 6:00 ~ 7:30 PM
Sun 7:00 AM ~ 11:00 AM

The weekday times may be changed due to my homework. (LOL)

Note: _There is a 14-hour time difference between New York City and Sydney_

@ghost
Copy link
Author

ghost commented May 7, 2016

Maybe we can have a Skype group. Do you people have Skype?

shure.

@joshgit
Copy link
Collaborator

joshgit commented May 8, 2016

I'm on the West Coast of the US.

@ghost
Copy link
Author

ghost commented May 8, 2016

So you are in California. (Probably.)

That's a _-3 / -4 hour time difference_

@ghost ghost unlocked this conversation May 8, 2016
@bortkiewicz
Copy link
Collaborator

Hello. I'm qlstudio. I know I'm not. I deleted my account. So why am I here?

ANSWER: testitem = qlstudio. Qlstudio got deleted

@bortkiewicz
Copy link
Collaborator

Should we turn this repo into an organization? I have a feeling one repo isn't enough to keep all the docs, servers, code, executables and versions.

@hanyuone
Copy link
Owner

Augh, I'm so frustrated with Tkinter... can't find a way to change what the buttons look like. Maybe we should just ditch the Python thing altogether and change the language to something like Javascript for web designing?

@bortkiewicz
Copy link
Collaborator

Simple: Replace buttons with Canvas and bind the Canvas to functions.

@bortkiewicz
Copy link
Collaborator

Oh shit. How on earth would we convert this into JavaScript? There are tools that convert Python into non-perfect JS, like JIPHY, but it doesn't include variable assignments.

@hanyuone
Copy link
Owner

hanyuone commented Jul 4, 2016

We have the basic idea for the game, we can just write the code from scratch - I already know enough JS to start (or we can use something like CoffeeScript instead). Every single feature will be easier to implement in Javascript. Every single one.

@bortkiewicz
Copy link
Collaborator

Oh... so are we going to convert this into JavaScript the same way we converted Python 2 into Python 3 before 0.7 came out?

@bortkiewicz
Copy link
Collaborator

So I created a handler for all the buttons. Its in JavaScript-Version/buttons.js

@hanyuone
Copy link
Owner

hanyuone commented Jul 6, 2016

I think we should ditch Python completely - there just aren't many options for idle-ish games in Python (except for Tkinter, perhaps, which is terrible) - and convert to Javascript.

@bortkiewicz
Copy link
Collaborator

What?? The buttons.js has NOTHING to do with Python! What do you expect, create buttons and handlers manually to detect which button is pressed? It's much easier with functions to handle them. There is enough description on how to create buttons in JS at KhanAcademy's "Intro to JS: Drawing and Animation".

@hanyuone
Copy link
Owner

hanyuone commented Jul 6, 2016

Wait, what? No, that last comment was for your "conversion" thing: I have a feeling we might rewrite the whole thing.

@bortkiewicz
Copy link
Collaborator

bortkiewicz commented Jul 6, 2016

Good. Right now the code is a pile of shit. So JS is quite familiar to you? I suggest you first attempting to write V0.1.3 in JS and see how it goes.

@hanyuone
Copy link
Owner

hanyuone commented Jul 9, 2016

LOL, yeah. I'm rewriting the WHOLE thing (up 'til V0.7.3) from scratch right now. Should we delete this repo and make a new one?

@bortkiewicz
Copy link
Collaborator

I was thinking we transform this into an organization, one repo Python and another JS and another the website. (Show me what you have now.)

@bortkiewicz
Copy link
Collaborator

"Right now the code is a pile of shit" Shit indeed. How would anyone find a function easily?

@hanyuone
Copy link
Owner

hanyuone commented Jul 9, 2016

Uh... I don't have much, to be honest. I'm slowly working up. Should I make a new repo?

Also, just saying, I'm going to be writing most of the code in CoffeeScript (which is Javascript with much better syntax).

@bortkiewicz
Copy link
Collaborator

groan I'm creating a Ways-to-not-make-money organization and I'm going to add you as an admin to it, ok?

@hanyuone
Copy link
Owner

hanyuone commented Jul 9, 2016

Sure, why not. Why the groan?

@bortkiewicz
Copy link
Collaborator

I created it already. I sent you an invitation.

@hanyuone
Copy link
Owner

hanyuone commented Jul 9, 2016

Where's the invitation?

@bortkiewicz
Copy link
Collaborator

Huh? Search for the organization ways-to-not-make-money on Github

@bortkiewicz
Copy link
Collaborator

@bortkiewicz
Copy link
Collaborator

hello?

@bortkiewicz
Copy link
Collaborator

Oh, check your email too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants