Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bilinear sqrt with sign #1

Closed
happywmzzz opened this issue Apr 18, 2018 · 2 comments
Closed

bilinear sqrt with sign #1

happywmzzz opened this issue Apr 18, 2018 · 2 comments

Comments

@happywmzzz
Copy link

Hi, it is a concise and useful code for bilinear CNNs, however, from the paper I read about the
" elementwise signed square-root (x ← sign(x)􏰊|x|) and l2 normalization is applied to the matrix A"
which means it should be multiplied by the sign. But in this code just "X = torch.sqrt(X + 1e-5)"

Am I missing something? and even this not same thoroughly, I got the same result (84.2%) which suggests it should be a right answer?

@HaoMood
Copy link
Owner

HaoMood commented Apr 19, 2018

Hi, thanks for your comment.

Since X is obtained from the relu5-3 activation of VGG, it is nonnegative elementwise. The bilinear result is nonnegative as well. Therefore, multiplying the sign or not does not affect the result.

Best regards,

Hao

@happywmzzz
Copy link
Author

yeah, that's right! I didn't thought the detail numerical value at that layer. thanks again~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants