Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling text modifier indexing #1831

Merged
merged 5 commits into from May 5, 2020

Conversation

jamesagnew
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #1831 into master will increase coverage by 0.01%.
The diff coverage is 96.07%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1831      +/-   ##
============================================
+ Coverage     81.22%   81.23%   +0.01%     
- Complexity    14034    14048      +14     
============================================
  Files           965      965              
  Lines         52617    52647      +30     
  Branches       8413     8421       +8     
============================================
+ Hits          42739    42770      +31     
  Misses         6671     6671              
+ Partials       3207     3206       -1     
Impacted Files Coverage Δ Complexity Δ
.../java/ca/uhn/fhir/jpa/model/util/JpaConstants.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...java/ca/uhn/fhir/jpa/model/entity/ModelConfig.java 92.42% <66.66%> (+0.48%) 29.00 <3.00> (+2.00)
...n/java/ca/uhn/fhir/context/RuntimeSearchParam.java 88.76% <100.00%> (+1.55%) 32.00 <1.00> (+2.00)
.../fhir/jpa/dao/predicate/PredicateBuilderToken.java 88.20% <100.00%> (+0.48%) 56.00 <0.00> (+2.00)
...earchparam/extractor/BaseSearchParamExtractor.java 87.56% <100.00%> (+0.33%) 152.00 <7.00> (+8.00)
...archparam/extractor/SearchParamExtractorDstu2.java 96.66% <100.00%> (ø) 11.00 <1.00> (ø)
...archparam/extractor/SearchParamExtractorDstu3.java 100.00% <100.00%> (ø) 8.00 <1.00> (ø)
.../searchparam/extractor/SearchParamExtractorR4.java 71.42% <100.00%> (ø) 7.00 <1.00> (ø)
.../searchparam/extractor/SearchParamExtractorR5.java 70.00% <100.00%> (ø) 6.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dada217...4e00483. Read the comment docs.

Copy link
Collaborator

@tadgh tadgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good minus a function I thought smelled logically a bit. I posted a potential replacement snippet if you're ok with that. Haven't tested it yet though, hapi still building...

Either way, approved!

@jamesagnew jamesagnew merged commit 35c2b7a into master May 5, 2020
@jamesagnew jamesagnew deleted the ja_20200505_disable_text_modifier branch May 5, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants