Process bundle batch in parallel #2905
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2905 +/- ##
============================================
- Coverage 82.58% 82.57% -0.02%
+ Complexity 19723 19720 -3
============================================
Files 1327 1327
Lines 70182 70228 +46
Branches 10736 10740 +4
============================================
+ Hits 57959 57989 +30
- Misses 8102 8115 +13
- Partials 4121 4124 +3
Continue to review full report at Codecov.
|
| //myExecutor.setMaxPoolSize(1); | ||
| myExecutor.setCorePoolSize(myDaoConfig.getBundleBatchPoolSize()); | ||
| myExecutor.setMaxPoolSize(myDaoConfig.getBundleBatchMaxPoolSize()); | ||
| myExecutor.setQueueCapacity(myDaoConfig.getBundleBatchQueueCapacity()); |
There was a problem hiding this comment.
Do we need the complexity of a queue? The main thread will wait for these to complete, so I wonder if we could delete this config.
There was a problem hiding this comment.
will delete this config
|
|
||
| myVersionAdapter.setResponseStatus(nextEntry, toStatusString(caughtEx.getException().getStatusCode())); | ||
| // waiting for all tasks to be completed | ||
| AsyncUtil.awaitLatchAndIgnoreInterrupt(completionLatch, 120L, TimeUnit.SECONDS); |
There was a problem hiding this comment.
Do we already have a request timeout configured somewhere? This feels too short for some customers.
There was a problem hiding this comment.
There is a connection timeout for 10000 milliseconds (10s). I can't find any other timeout value. The value here is 120s (2m). I can change it to 5m (300s).
No description provided.