Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batching of mdm-clear tasks #3295

Merged

Conversation

IanMMarshall
Copy link
Collaborator

No description provided.

@IanMMarshall
Copy link
Collaborator Author

Found an issue in the $mdm-clear batch operation that appears to be similar to one recently fixed for reindexing as part of #3211.

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #3295 (301519e) into master (55ad98d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3295      +/-   ##
============================================
- Coverage     82.82%   82.82%   -0.01%     
- Complexity    20377    20379       +2     
============================================
  Files          1366     1366              
  Lines         73172    73174       +2     
  Branches      11010    11011       +1     
============================================
+ Hits          60606    60607       +1     
- Misses         8346     8349       +3     
+ Partials       4220     4218       -2     
Impacted Files Coverage 螖
.../ca/uhn/fhir/jpa/batch/mdm/job/MdmLinkDeleter.java 89.47% <100.00%> (酶)
...a/ca/uhn/fhir/jpa/dao/expunge/PartitionRunner.java 73.01% <100.00%> (+0.88%) 猬嗭笍
...a/ca/uhn/fhir/rest/openapi/OpenApiInterceptor.java 86.39% <0.00%> (-0.40%) 猬囷笍
...or/TransactionConcurrencySemaphoreInterceptor.java 85.29% <0.00%> (+1.47%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 55ad98d...301519e. Read the comment docs.

@IanMMarshall IanMMarshall merged commit e6fd5c9 into master Jan 13, 2022
@IanMMarshall IanMMarshall deleted the 3294-mdm-clear-throws-ResourceVersionConflictExceptions branch January 13, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDM clear operation throwing ResourceVersionConflictExceptions when reindex thread count is greater than 1
2 participants