Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Group Bulk Export rules conflict #3642

Closed
tadgh opened this issue May 24, 2022 · 0 comments · Fixed by #3643
Closed

Multiple Group Bulk Export rules conflict #3642

tadgh opened this issue May 24, 2022 · 0 comments · Fixed by #3643

Comments

@tadgh
Copy link
Collaborator

tadgh commented May 24, 2022

The current implementation of the RuleBulkExportImpl returns a DENY if the group ID does not match, but it is possible for another rule to match. E.g. if we were to write the following rules:

				return new RuleBuilder()
					.allow().bulkExport().groupExportOnGroup(new IdType("Group/123")).andThen()
					.allow().bulkExport().groupExportOnGroup(new IdType("Group/789")).andThen()
					.build();

This would cause a failure for somebody attempting to export Group/789, as first the Group/123 rule is hit, and it returns a deny. If instead it returns null, it can delegate to further rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant