Start moving forced-id inline to ResourceTable #4260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 81.00% // Head: 81.16% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4260 +/- ##
============================================
+ Coverage 81.00% 81.16% +0.15%
- Complexity 23466 23498 +32
============================================
Files 1446 1439 -7
Lines 86175 86107 -68
Branches 11798 11745 -53
============================================
+ Hits 69809 69887 +78
+ Misses 11087 10989 -98
+ Partials 5279 5231 -48
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jamesagnew
approved these changes
Nov 9, 2022
hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/6_3_0/4260-inline-forcedid.yaml
Outdated
Show resolved
Hide resolved
hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/6_3_0/4260-inline-forcedid.yaml
Outdated
Show resolved
Hide resolved
...r-jpaserver-test-dstu3/src/test/java/ca/uhn/fhir/jpa/dao/dstu3/FhirResourceDaoDstu3Test.java
Outdated
Show resolved
Hide resolved
...r-jpaserver-test-dstu3/src/test/java/ca/uhn/fhir/jpa/dao/dstu3/FhirResourceDaoDstu3Test.java
Outdated
Show resolved
Hide resolved
…_3_0/4260-inline-forcedid.yaml Co-authored-by: James Agnew <jamesagnew@gmail.com>
…_3_0/4260-inline-forcedid.yaml Co-authored-by: James Agnew <jamesagnew@gmail.com>
…d-id-inline * commit '9a45576793a279ba1722853ab7c847745595b22e': Cache service loaders (#4196) Post release HAPI FHIR cleanup (#4266) Bump log4j-to-slf4j from 2.17.1 to 2.19.0 (#4265) ValueSet cleanup (#4227) Rel 6 2 mergeback (#4257) Issue 4180 process slows down to a crawl while loading uscore ig (#4201)
Ensure we flush, and check resource version.
lukedegruchy
approved these changes
Nov 14, 2022
hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/entity/ResourceTable.java
Outdated
Show resolved
Hide resolved
jamesagnew
reviewed
Nov 14, 2022
...r-jpaserver-test-dstu3/src/test/java/ca/uhn/fhir/jpa/dao/dstu3/FhirResourceDaoDstu3Test.java
Show resolved
Hide resolved
tadgh
approved these changes
Nov 14, 2022
...ir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/migrate/tasks/HapiFhirJpaMigrationTasks.java
Show resolved
Hide resolved
hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/entity/ResourceTable.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The join to HFJ_FORCED_ID is expensive. We are starting to move it into HFJ_RESOURCE. To allow zero-downtime upgrades, we are doing this in three steps:
This PR implements step 1.