New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPS Generator #4438
Add IPS Generator #4438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat. Minor comments/questions.
hapi-fhir-base/src/main/java/ca/uhn/fhir/narrative2/BaseNarrativeGenerator.java
Outdated
Show resolved
Hide resolved
hapi-fhir-base/src/main/java/ca/uhn/fhir/fhirpath/IFhirPathEvaluationContext.java
Show resolved
Hide resolved
hapi-fhir-base/src/main/java/ca/uhn/fhir/fhirpath/IFhirPathEvaluationContext.java
Show resolved
Hide resolved
hapi-fhir-base/src/main/java/ca/uhn/fhir/narrative/BaseThymeleafNarrativeGenerator.java
Outdated
Show resolved
Hide resolved
hapi-fhir-base/src/main/java/ca/uhn/fhir/narrative2/NarrativeTemplateManifest.java
Outdated
Show resolved
Hide resolved
hapi-fhir-base/src/main/java/ca/uhn/fhir/narrative2/NarrativeTemplateManifest.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-ips/src/main/java/ca/uhn/fhir/jpa/ips/api/IpsContext.java
Show resolved
Hide resolved
hapi-fhir-jpaserver-ips/src/main/java/ca/uhn/fhir/jpa/ips/api/SectionRegistry.java
Show resolved
Hide resolved
Codecov ReportBase: 81.32% // Head: 81.35% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4438 +/- ##
============================================
+ Coverage 81.32% 81.35% +0.02%
- Complexity 23650 23795 +145
============================================
Files 1425 1432 +7
Lines 86399 87219 +820
Branches 11677 11768 +91
============================================
+ Hits 70265 70956 +691
- Misses 10947 11035 +88
- Partials 5187 5228 +41
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jamesagnew for your painstaking and elegant work! I have added some notes here to compare to the original functionality and few spots where I'm not sure it's behaving entirely as intended. Sorry these comments are coming on a closed PR. I only became aware the work was done after it was already closed.
This PR adds a generation API for International Patient Summary (IPS) documents. As a part of implementing this, I also reworked the narrative generator to improve profile support, add thymeaf fragment template support, and added a method to generate narratives without populating any resources.