Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPS Generator #4438

Merged
merged 32 commits into from Jan 24, 2023
Merged

Add IPS Generator #4438

merged 32 commits into from Jan 24, 2023

Conversation

jamesagnew
Copy link
Collaborator

@jamesagnew jamesagnew commented Jan 17, 2023

This PR adds a generation API for International Patient Summary (IPS) documents. As a part of implementing this, I also reworked the narrative generator to improve profile support, add thymeaf fragment template support, and added a method to generate narratives without populating any resources.

@jamesagnew jamesagnew changed the title **Not ready for review yet**: Add IPS Generator Add IPS Generator Jan 19, 2023
Copy link
Contributor

@michaelabuckley michaelabuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. Minor comments/questions.

@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Base: 81.32% // Head: 81.35% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (4fab7c9) compared to base (2f5ffe7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4438      +/-   ##
============================================
+ Coverage     81.32%   81.35%   +0.02%     
- Complexity    23650    23795     +145     
============================================
  Files          1425     1432       +7     
  Lines         86399    87219     +820     
  Branches      11677    11768      +91     
============================================
+ Hits          70265    70956     +691     
- Misses        10947    11035      +88     
- Partials       5187     5228      +41     
Impacted Files Coverage Δ
ca/uhn/fhir/mdm/api/MdmQuerySearchParameters.java 49.31% <0.00%> (-35.94%) ⬇️
org/hl7/fhir/r5/hapi/fhirpath/FhirPathR5.java 40.74% <0.00%> (-28.01%) ⬇️
...a/uhn/fhir/jpa/mdm/svc/MdmLinkQuerySvcImplSvc.java 41.66% <0.00%> (-25.00%) ⬇️
org/hl7/fhir/r4/hapi/fluentpath/FhirPathR4.java 62.96% <0.00%> (-24.54%) ⬇️
.../hl7/fhir/dstu3/hapi/fluentpath/FhirPathDstu3.java 76.00% <0.00%> (-17.75%) ⬇️
ca/uhn/fhir/jpa/mdm/svc/MdmControllerSvcImpl.java 63.44% <0.00%> (-9.40%) ⬇️
...r/narrative/CustomThymeleafNarrativeGenerator.java 94.73% <0.00%> (-5.27%) ⬇️
ca/uhn/fhir/system/HapiSystemProperties.java 76.47% <0.00%> (-4.78%) ⬇️
...rch/PersistedJpaSearchFirstPageBundleProvider.java 95.65% <0.00%> (-2.03%) ⬇️
ca/uhn/fhir/rest/api/MethodOutcome.java 81.03% <0.00%> (-1.66%) ⬇️
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jamesagnew jamesagnew merged commit d584e14 into master Jan 24, 2023
@jamesagnew jamesagnew deleted the ja_20230113_ips branch January 24, 2023 17:07
@jamesagnew jamesagnew mentioned this pull request Jan 25, 2023
Copy link

@riobennin riobennin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jamesagnew for your painstaking and elegant work! I have added some notes here to compare to the original functionality and few spots where I'm not sure it's behaving entirely as intended. Sorry these comments are coming on a closed PR. I only became aware the work was done after it was already closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants