Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance level reindex operations #4699

Merged
merged 22 commits into from Apr 6, 2023
Merged

Conversation

jamesagnew
Copy link
Collaborator

This PR adds an instance level $reindex operation, as well as a dry-run equivalent for testing reindexing

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.27 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (9f7f2b0) 81.60%.

❗ Current head 9f7f2b0 differs from pull request most recent head 085757f. Consider uploading reports for the commit 085757f to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4699      +/-   ##
============================================
+ Coverage     81.32%   81.60%   +0.27%     
- Complexity    23650    24420     +770     
============================================
  Files          1425     1470      +45     
  Lines         86399    89409    +3010     
  Branches      11677    12015     +338     
============================================
+ Hits          70265    72963    +2698     
- Misses        10947    11142     +195     
- Partials       5187     5304     +117     

see 1419 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@jmarchionatto jmarchionatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few todos and comments

Copy link
Collaborator

@jmarchionatto jmarchionatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great piece of work!

@jamesagnew jamesagnew merged commit e500b23 into master Apr 6, 2023
61 checks passed
@jamesagnew jamesagnew deleted the ja_20230314_reindex_improverments branch April 6, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants