New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict bulk export download to specific user #5052
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fil512
approved these changes
Jul 3, 2023
hapi-fhir-storage-batch2-jobs/src/main/java/ca/uhn/fhir/batch2/jobs/export/WriteBinaryStep.java
Outdated
Show resolved
Hide resolved
...st/java/ca/uhn/fhir/rest/server/interceptor/binary/BinarySecurityContextInterceptorTest.java
Show resolved
Hide resolved
...st/java/ca/uhn/fhir/rest/server/interceptor/binary/BinarySecurityContextInterceptorTest.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-test-r4/src/test/java/ca/uhn/fhir/jpa/bulk/BulkDataExportTest.java
Show resolved
Hide resolved
michaelabuckley
approved these changes
Jul 4, 2023
hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/docs/security/introduction.md
Outdated
Show resolved
Hide resolved
hapi-fhir-server/src/main/java/ca/uhn/fhir/rest/api/server/bulk/BulkExportJobParameters.java
Show resolved
Hide resolved
hapi-fhir-storage-batch2-jobs/src/main/java/ca/uhn/fhir/batch2/jobs/export/WriteBinaryStep.java
Show resolved
Hide resolved
hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/docs/security/binary_security_interceptor.md
Show resolved
Hide resolved
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5052 +/- ##
============================================
+ Coverage 81.32% 83.20% +1.88%
- Complexity 23650 25587 +1937
============================================
Files 1425 1563 +138
Lines 86399 93393 +6994
Branches 11677 12403 +726
============================================
+ Hits 70265 77709 +7444
+ Misses 10947 10216 -731
- Partials 5187 5468 +281 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new interceptor which allows locking bulk export downloads to just a specific user