Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDM Score for No Match Fields Should Not Be Included in Total Score #5117

Open
jdar8 opened this issue Jul 21, 2023 · 0 comments
Open

MDM Score for No Match Fields Should Not Be Included in Total Score #5117

jdar8 opened this issue Jul 21, 2023 · 0 comments

Comments

@jdar8
Copy link
Collaborator

jdar8 commented Jul 21, 2023

NOTE: Before filing a ticket, please see the following URL:
https://github.com/hapifhir/hapi-fhir/wiki/Getting-Help

Describe the bug
When MDM has a Possible Match, the score of "no match" also added into total score.

To Reproduce
Steps to reproduce the behavior:

  1. Setup MDM, enable trouble shooting logs
  2. Create Patient/1 --> new GR created
  3. Create Patient/2 such that it will be a POSSIBLE_MATCH and at least one MDM Match Field that uses a similarity algorithm does not match
  4. Check troubleshooting log. Score for Patient/2 includes the no match similarity field score

Expected behavior
Score for Patient/2 SHOULD NOT include the no match similarity field score: "search score field that is calculated by averaging the number of matched rules against total rules checked for the Patient resource" in 7.3.1 in docs (https://hapifhir.io/hapi-fhir/docs/server_jpa_mdm/mdm_operations.html)

@jdar8 jdar8 changed the title Score for No Match Fields Should Not Be Included in Total Score MDM Score for No Match Fields Should Not Be Included in Total Score Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant