Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing empty last page if even results #5229

Closed
wants to merge 39 commits into from

Conversation

TipzCM
Copy link
Collaborator

@TipzCM TipzCM commented Aug 23, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 23, 2023

Formatting check succeeded!

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f5ffe7) 81.32% compared to head (a87fde7) 82.90%.
Report is 362 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5229      +/-   ##
============================================
+ Coverage     81.32%   82.90%   +1.57%     
- Complexity    23650    26594    +2944     
============================================
  Files          1425     1644     +219     
  Lines         86399   103311   +16912     
  Branches      11677    13180    +1503     
============================================
+ Hits          70265    85651   +15386     
- Misses        10947    12026    +1079     
- Partials       5187     5634     +447     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@michaelabuckley michaelabuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the offset path looks good. I think the changes to the saved-search path is redundant. Can you test that path with these changes backed out?

@TipzCM TipzCM enabled auto-merge (squash) November 27, 2023 19:41
@TipzCM TipzCM closed this Nov 28, 2023
auto-merge was automatically disabled November 28, 2023 20:07

Pull request was closed

@nathandoef
Copy link
Collaborator

Duplicate of: #5506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants