Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue that OpenAPI specification had errors when validating it against Swagger/OpenAPI schema and Swagger/OpenAPI spec #5465

Merged
merged 4 commits into from Jan 9, 2024

Conversation

delopst
Copy link
Contributor

@delopst delopst commented Nov 19, 2023

HAPI Fhir OpenAPI specification has errors when validating it against Swagger/OpenAPI schema and Swagger/OpenAPI spec (https://apitools.dev/swagger-parser/online/).

With this commit, validation is passing.

Primož Delopst and others added 2 commits November 19, 2023 14:09
Copy link
Collaborator

@jamesagnew jamesagnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@jamesagnew
Copy link
Collaborator

I've marked for approval, but I do note that several OpenAPI unit tests are failing so this probably needs a bit of cleanup before it can be merged. Thanks!

@delopst
Copy link
Contributor Author

delopst commented Nov 19, 2023

I see. The problem was that there was already a different swagger version in the root pom.
I have consolidated them. At least locally the ServerDstu3Test that was failing before is now passing.

@delopst
Copy link
Contributor Author

delopst commented Nov 19, 2023

It seems like the tests are passing now. @jamesagnew this can probably be merged now?

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f5ffe7) 81.32% compared to head (5447c57) 83.32%.
Report is 415 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5465      +/-   ##
============================================
+ Coverage     81.32%   83.32%   +2.00%     
- Complexity    23650    26667    +3017     
============================================
  Files          1425     1646     +221     
  Lines         86399   103158   +16759     
  Branches      11677    13121    +1444     
============================================
+ Hits          70265    85961   +15696     
- Misses        10947    11558     +611     
- Partials       5187     5639     +452     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesagnew jamesagnew merged commit adfdbab into hapifhir:master Jan 9, 2024
63 of 65 checks passed
@jamesagnew
Copy link
Collaborator

Thanks for the contribution! This will be in release 7.0.0, and should appear in snapshot builds tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants