Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination and search response times #860

Closed
ghiron opened this issue Feb 22, 2018 · 2 comments
Closed

Pagination and search response times #860

ghiron opened this issue Feb 22, 2018 · 2 comments
Labels

Comments

@ghiron
Copy link

ghiron commented Feb 22, 2018

Hi !

we made some performance tests on search requests after our migration to the ES search engine (#742).. We still have some pretty slow response times (e.g over 5s on ~600k rows).

I looked into code and I see two main reasons of this latency :

  • Search results are stored into the database and the system trues to fetch all results (in an extra thread) from the DB even if only one result is required
  • Pagination is done at the "controller" layer instead of using the DB/Elasticsearch pagination capability. Because of that, a lot of data is fetched from the DB.

Primary tests I've done, show an improvement on response time and response time stability if search result storage is removed and pagination is used at DB layer.

I plan to make a PR with these modifications :

  • Move the Pagination from the controller to DAO layer
  • Disable the search result storage

This PR would at this time break a feature like *BaseSubscriptionInterceptor but we welcome more insight into how the feature is used currently to adapt our PR. This PR would also impact several method and interface signatures which will be updated.

We welcome any feedback !

this issue looks related to
#481
#536

@storni
Copy link

storni commented Feb 26, 2018

Hi @ghiron, have you arrived to a solution?

BTW, I've found a way to improve the performance of the search result storage with minimal changes in the code. See #866 for details.

@stale
Copy link

stale bot commented Mar 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants