Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We probably shouldn't have hard coded directories in the methods to find the FHIR_HOME dir. #175

Closed
markiantorno opened this issue Apr 17, 2020 · 3 comments

Comments

@markiantorno
Copy link
Collaborator

No description provided.

@markiantorno
Copy link
Collaborator Author

In TestUtilities, there is a method to get the home directory:

  public static String home() {
    if (fixedpath != null)
     return fixedpath;
    String s = System.getenv("FHIR_HOME");
    if (!Utilities.noString(s))
      return s;
    s = "C:\\work\\org.hl7.fhir\\build";
    if (new File(s).exists())
      return s;
    throw new Error("FHIR Home directory not configured");
  }

Having a hard coded C: path here isn't the right approach. We need to accommodate different OS.

I'll fix this, I am just putting it here to remember, because I have the memory of a goldfish.

@markiantorno markiantorno changed the title We can' We probably shouldn't have hard coded directories in the methods to find the FHIR_HOME dir. Apr 18, 2020
@grahamegrieve
Copy link
Collaborator

But how are we going to fix this?

@markiantorno
Copy link
Collaborator Author

I fixed this as part of #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants