Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Validator doesn't Exit with Non-Zero Code on Errors #69

Closed
alexanderkiel opened this issue Aug 13, 2019 · 2 comments
Closed

CLI Validator doesn't Exit with Non-Zero Code on Errors #69

alexanderkiel opened this issue Aug 13, 2019 · 2 comments

Comments

@alexanderkiel
Copy link
Contributor

We like to use the Validator Jar on command line in CI to validate our profiles against examples. For CI it would be very helpful, if the validator wouldn't exit with code zero on errors so the CI errors also.

@grahamegrieve
Copy link
Collaborator

ok done next release - will now exit with error code == number of errors found

@alexanderkiel
Copy link
Contributor Author

Thanks @grahamegrieve. Unfortunately using the number of errors as exit code isn't the way exit codes are used normally (at least in POSIX - not sure about Windows). The concrete exit code should describe the class of error occurred. Just using 1 for all error cases is good enough. Here is a good read: https://shapeshed.com/unix-exit-codes/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants