Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator isn't checking that slices actually assert fixed values or patterns as the discriminator type calls for #753

Open
lmckenzi opened this issue Mar 1, 2022 · 4 comments
Labels
bug Something isn't working validation-core

Comments

@lmckenzi
Copy link
Collaborator

lmckenzi commented Mar 1, 2022

See https://jira.hl7.org/issues/?filter=16724 for a detailed example. In the example, the discriminator location is erroneously defined as "$this" when it should be "code". However, the validator doesn't notice or yell. The validator should ensure that each slice has the discriminator element and constraint defined (i.e. fixed value, required value set or pattern when slicing by value; pattern when slicing by pattern, data type when slicing by type, and profile or target profile when slicing by profile).

@lmckenzi lmckenzi added bug Something isn't working validation-core labels Mar 1, 2022
@stale
Copy link

stale bot commented Aug 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 31, 2022
@lmckenzi lmckenzi removed the wontfix This will not be worked on label Aug 31, 2022
@stale
Copy link

stale bot commented Feb 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 22, 2023
@lmckenzi lmckenzi removed the wontfix This will not be worked on label Feb 22, 2023
@stale
Copy link

stale bot commented Aug 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 18, 2023
@lmckenzi lmckenzi removed the wontfix This will not be worked on label Aug 18, 2023
Copy link

stale bot commented Feb 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 13, 2024
@lmckenzi lmckenzi removed the wontfix This will not be worked on label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working validation-core
Projects
None yet
Development

No branches or pull requests

1 participant