Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to allow custom Client authentication #285

Closed
cvillerm opened this issue Dec 22, 2016 · 3 comments
Closed

Need to allow custom Client authentication #285

cvillerm opened this issue Dec 22, 2016 · 3 comments
Labels
feature New functionality or improvement

Comments

@cvillerm
Copy link
Contributor

To allow custom OAuth2 Client authentication, it should be possible to pass client secrets as something else than a password. An example when using PingFederate as custom provider is the ability to use client-certificate-based authentication to authenticate the client with the token endpoint: https://documentation.pingidentity.com/pingfederate/pf81/index.shtml#concept_configuringClient.html

I am about to create a PR to support this, by allowing the clientSecret parameter to be passed as an object, contains options to be merged with the Wreck request options used when calling the token endpoint.

@cvillerm
Copy link
Contributor Author

PR #286 submitted

@ldesplat ldesplat added the feature New functionality or improvement label Jan 26, 2017
@ldesplat
Copy link
Contributor

Closed by c8781d9

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New functionality or improvement
Projects
None yet
Development

No branches or pull requests

2 participants