Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expect(<'', [], or {}>).to.only.include('foo') passes #143

Closed
samliebow opened this issue Aug 12, 2019 · 2 comments
Closed

expect(<'', [], or {}>).to.only.include('foo') passes #143

samliebow opened this issue Aug 12, 2019 · 2 comments
Assignees
@hueniverse
Labels
bug Bug or defect dependency Update module dependency

Comments

@samliebow
Copy link

Due to an issue in Hoek 6.0.2+, expect().to.only.include() always passes if the value in the expect() is an empty string, array, or object. This bug was introduced into Code in 5.2.2 via upgrading the Hoek version.
@hueniverse
Copy link
Contributor

Fix in hoek@8.2.1

@hueniverse hueniverse self-assigned this Aug 12, 2019
@hueniverse hueniverse added bug Bug or defect dependency Update module dependency labels Aug 12, 2019
@samliebow samliebow mentioned this issue Aug 20, 2019
Closed
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hueniverse hueniverse

Labels
bug Bug or defect dependency Update module dependency
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hueniverse @samliebow