Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to README #215

Closed
grahamnordstrom opened this issue Jun 5, 2019 · 3 comments
Closed

Update to README #215

grahamnordstrom opened this issue Jun 5, 2019 · 3 comments
Assignees
Labels
documentation Non-code related changes

Comments

@grahamnordstrom
Copy link

I have figured out the issue. When I declared the parameter, never before specified the path. Now with version 10 the path will be defaulted for the specific url path, that is why I could not see the cookie on the new url, because only applied to the previous old one. I had to add path: '/' to the initial options and it started to work.

Originally posted by @CloudVector in #211 (comment)

@grahamnordstrom
Copy link
Author

Would be helpful to mention this in the README or in the upgrade path.
Alternatively the path could default to '/' as it appears that the cookie isn't set / accessible without it being explicitly set.

@hueniverse
Copy link
Contributor

This was noted in the release notes but lacked full explanation of the impact. I updated the notes.

@hueniverse hueniverse self-assigned this Sep 12, 2019
@hueniverse hueniverse added the documentation Non-code related changes label Sep 12, 2019
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Non-code related changes
Projects
None yet
Development

No branches or pull requests

2 participants