Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove $env support from pack.compose() #2016

Closed
hueniverse opened this issue Oct 8, 2014 · 0 comments
Closed

Remove $env support from pack.compose() #2016

hueniverse opened this issue Oct 8, 2014 · 0 comments
Assignees
@hueniverse
Labels
breaking changes Change that can breaking existing code
Milestone
7.0.0

Comments

@hueniverse
Copy link
Contributor

The current feature in pack.compose() was added to support the cli tool. Now that the cli has its own parser for '$env.' prefixed values, this is no longer needed. Since this affects pack.compose() only when called directly, the manifest can just be modified outside with the right values.
@hueniverse hueniverse added the breaking changes Change that can breaking existing code label Oct 8, 2014
@hueniverse hueniverse self-assigned this Oct 8, 2014
@hueniverse hueniverse added this to the 6.11.2 milestone Oct 8, 2014
@hueniverse hueniverse modified the milestones: 6.11.2, 7.0.0 Oct 8, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jan 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hueniverse hueniverse

Labels
breaking changes Change that can breaking existing code
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
1 participant
@hueniverse