Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public API for Registered Plugins #2777

Closed
arb opened this issue Sep 21, 2015 · 4 comments
Closed

Public API for Registered Plugins #2777

arb opened this issue Sep 21, 2015 · 4 comments
Assignees
Labels
Milestone

Comments

@arb
Copy link
Contributor

@arb arb commented Sep 21, 2015

Can we add a method to return all of the registered plugins on a connection? The use case is to provide a comprehensive data point about everything going on inside a hapi server, including registered plugins. Currently, I'm using connection._registrations which is obviously not a good, long term solution.

@devinivy
Copy link
Member

@devinivy devinivy commented Oct 1, 2015

I agree that this would be worthwhile. Even a simple list of registered plugin names and versions could be hugely useful.

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Oct 2, 2015

The problem is, we don't really know what's going on...

There are two types of plugins, those that change the server only and those that change the connections (and maybe the server). If you load the server-only first, then add a connection, the list will be missing the registration but it will be there. We need the plugin to tell hapi what it is doing for a better outcome. I am working on this elsewhere.

@devinivy
Copy link
Member

@devinivy devinivy commented Oct 2, 2015

So _registrations will not contain those "server-only first" plugin registrations, correct?

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Oct 2, 2015

It will now with the new connections flag.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants