Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response method terms - encoding() vs charset() #983

Closed
atomless opened this issue Jul 17, 2013 · 1 comment · Fixed by #997
Closed

Response method terms - encoding() vs charset() #983

atomless opened this issue Jul 17, 2013 · 1 comment · Fixed by #997
Assignees
Labels
breaking changes Change that can breaking existing code bug Bug or defect
Milestone

Comments

@atomless
Copy link
Contributor

Reading the docs here : https://github.com/spumko/hapi/blob/master/docs/Reference.md#generic I was thrown initially by the terminology used where encoding refers to the charset. Would it perhaps be more intuitive to use charset() instead of encoding()? I would expect encoding to refer to whether it's gzipped - see charset and encoding sections here : http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html

@hueniverse
Copy link
Contributor

We might need to break the method into two... encoding is really used to turn strings into buffers for sending data on the wire. But we also use it to set the character set header. That's probably wrong.

@ghost ghost assigned hueniverse Jul 22, 2013
@geek geek closed this as completed in #997 Jul 22, 2013
@lock lock bot locked as resolved and limited conversation to collaborators Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking changes Change that can breaking existing code bug Bug or defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants