Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transform method does not respect separator option #124

Closed
kanongil opened this issue Feb 6, 2015 · 2 comments
Closed

transform method does not respect separator option #124

kanongil opened this issue Feb 6, 2015 · 2 comments
Assignees
@nlf
Labels
breaking changes Change that can breaking existing code bug Bug or defect
Milestone
4.0.0

Comments

@kanongil
Copy link
Contributor

kanongil commented Feb 6, 2015

The docs say that transform uses the same options as reach, however it does not respect the separator option for the keys in the transform parameter.
@nlf nlf added the bug Bug or defect label Mar 24, 2015
@nlf nlf added this to the 2.12.0 milestone Mar 24, 2015
@nlf nlf self-assigned this Mar 24, 2015
@nlf nlf removed this from the 2.12.0 milestone Mar 24, 2015
@nlf
Copy link
Member

nlf commented Mar 24, 2015

Currently the separator option is respected for the values in the transform, but not the keys. This is likely going to end up being a breaking change, so I'm going to hold off on it for a little while since I may have another breaking change coming soon.

@nlf nlf added the breaking changes Change that can breaking existing code label Apr 25, 2016
@nlf nlf added this to the 4.0.0 milestone Apr 25, 2016
@nlf nlf closed this as completed in 07abda1 Apr 25, 2016
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nlf nlf

Labels
breaking changes Change that can breaking existing code bug Bug or defect
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@nlf @kanongil