Browser support without DNS check

[edorivai]

Hey!

This lib comes out on top when searching npms.io for email validators. However, due to the dependency on node's dns, we're unable to use it in the browser. In my case, I only want to use the simple, synchronous validation without the DNS check.

Would you guys consider not requiring dns for the synchronous case?

[Marsup]

Why don't you just ignore dns in your bundler ?

[edorivai]

Ah, managed to get it to work according to hapijs/joi#748 (comment)

Perhaps worth mentioning in the docs?

Thanks for the hint!

[samhh]

This seems like something that would surely be better fixed in the library itself, rather than polluting bundler configs?

[tuchk4]

node: {
  dns: 'mock',
  net: 'mock'
}

But this workaround will not work with create-react-app

[tuchk4]

Workaround for create-react-app

Setup NODE_PATH - directory name to be resolved to the current directory as well as its ancestors, and searched for modules. It is resolve.modulesDirectories for webpack. More details at node official doc "Loading from the global folders"

And then two ways:

• create dns dir at the NOTE_PATH root and index.js inside
• create dns.js file and the NODE_PATH root

Script source can be empty:

module.exports = {};

But also you could re-export dns mocks if needed.

[tamaccount]

Could someone perhaps add clearer instructions to this workaround? Perhaps the image tuchk4 provided better showed what he was describing but now the image is no longer working.

I am confused about:

• where in my workspace to add the NODE_PATH folder and what should go in it?
• and do I just include in the folder a js file called dns.js which simply reads

module.exports = {};

?

Any help would be much appreciated. Thank you.

[egonvb]

Here's my solution with create-react-app

create a folder dns ( mine is in src/mock/dns )
add file index.js to folder containing :

module.exports = {};
module.exports.default = {};

add file package.json to folder containing:

{
  "name": "dns",
  "version": "3.1.0",
  "private": true
}

Open your package.json and add following line to the dependencies

"dns" : "file:./src/mock/dns",

run "npm install"

[WesTyler]

FWIW we are currently working on removing the dns dependency from isemail entirely. You can follow along here.

[arushi011]

@egonvb can you please make it more clear . I am stuck here

[egonvb]

hi, please explain your problem in an email. i'll see if i can help you. it's been a while, the reply on github was 9 months ago ;-) regards, Egon Verbakel Op 14 jan. 2018 11:00 a.m. schreef "Arushi Bajpai" <notifications@github.com

:

@egonvb <https://github.com/egonvb> can you please make it more clear . I am stuck here — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#26 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABbFrWxZnMBtEmg-c-3beEuZikbQgZg_ks5tKdAhgaJpZM4JoQs0> .

[WesTyler]

Version 3 of this package no longer does the DNS checking, so that dependency is removed entirely. Let me know if you have trouble using version 3.

[sleepydistrict]

@WesTyler I just had this problem come up. It seems like what @egonvb suggested worked. Im going to move forward and find out.

[WesTyler]

@sleepydistrict can you confirm what version of isemail you're using? I just want to make sure this isn't an ongoing issue with version 3.

[benjiwheeler]

Sure seems to me like it's a problem that if you add isemail to your package.json, install it, and use it in your node code, it... makes your entire node app unusable

[WesTyler]

I would suggest opening a new issue with some helpful details if this is an accurate description of your experience.

On Tue, Aug 6, 2019 at 4:46 PM Benjamin Wheeler ***@***.***> wrote: Sure seems to me like it's a problem that if you add isemail to your package.json, install it, and use it in your node code, it... makes your entire node app unusable — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#26?email_source=notifications&email_token=AC4XQO2QL2PQOZLLITHVEMLQDIEMPA5CNFSM4CNBBM2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3WYVCQ#issuecomment-518883978>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC4XQOYGMWJUII2BVT64KO3QDIEMPANCNFSM4CNBBM2A> .

-- None

[benjiwheeler]

I would suggest opening a new issue with some helpful details if this is an accurate description of your experience.

Fair!