coerce arguments order is incorrect

[NikhilNanjappa-zz]

Context

• node version: 10.4.0
• joi version: 16.1.1
• environment (node, browser): node
• used with (hapi, standalone, ...): hapi
• any other relevant information: No

What are you trying to achieve or the steps to reproduce ?

Following the new doc for extensions and some examples in the release notes, I'm trying to coerce values as shown in the below example.

The issue is that, the order of the arguments seems to be wrong. It says its supposed to coerce(schema, value, helpers) but what I actually get is coerce(value, schema, ...). Mentioned below the actual value it returns.

Itseems to behave as per previous version. Maybe I'm doing something wrong ?

const baseJoi = require('@hapi/joi16');
const Joi = baseJoi.extend(require('./friendly-number'));

const schema = Joi.friendlyNumber().required();
schema.validate('1,000');

The friendly-number code looks like:

module.exports = function(joi) {
    return {
        type: 'friendlyNumber',
        base: joi.number(),
        coerce(schema, value, helpers) {
            console.log(schema); // this returns the value => 1,000
            console.log(value); // this returns the schema => "value { original: '1,000', prefs: ..."
            console.log(helpers); // this returns undefined
        }
    };
};

Which result you had ?

Logging the schema argument gave me the value and value gave me schema and helpers gave me undefined.

What did you expect ?

schema, value, helpers to log its own values.

[Marsup]

I'm not sure I understand the relationship with v15 but documentation is now fixed.

[NikhilNanjappa-zz]

Thanks. Edited the title to avoid ambiguity.

I'm also a bit confused relating to another issue with same coerce function. The result of schema.validate('1,000').value returns a string instead of converting it to a number. My code looks like (I used the syntax from the release notes instead of the API doc):

        ...
        coerce: {
            from: 'string',
            method(value) {
                if (isString(value)) {
                    // Strip out any non-numeric characters (eg. ,) but keep decimal points
                    return { value: value.replace(/[^0-9.]/g, '') };
                }
                return { value };
            }
        }

Am I missing something @Marsup ?

[Marsup]

You should use prepare for that. Same as your 1st try but coerce ➡️ prepare. It's not well documented currently but it'll come.

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.