string().uri() not working with accented characters

[mlarcher]

Support plan

• is this issue currently blocking your project? (yes/no): yes
• is this issue affecting a production system? (yes/no): yes

Context

• node version: 18.10.0
• module version with issue: 17.1.1
• last module version without issue:
• environment (e.g. node, browser, native): node
• used with (e.g. hapi application, another framework, standalone, ...):
• any other relevant information:

What are you trying to achieve or the steps to reproduce?

const { error } = Joi.string().uri().validate('https://linkedin.com/in/aïssa/');
console.log(error); // there should be no error

What was the result you got?

"value" must be a valid uri] {
  _original: 'https://linkedin.com/in/aïssa/',
  details: [
    {
      message: '"value" must be a valid uri',
      path: [],
      type: 'string.uri',
      context: [Object]
    }
  ]
}

What result did you expect?

no error

Same check with a i instead of the ï in aïssa in the url works as expected

[geeksilva97]

Hello, @mlarcher. I think if you do something like

const encodedUsername = encodeURIComponent('aïssa');

const { error } = Joi.string().uri().validate(`https://linkedin.com/in/${encodedUsername}`);
console.log(error); // undefined

it might work.

However, I also think it could be handled by the lib.

[Marsup]

It is rejected because it is invalid. There's a well-written answer on SO.

[mlarcher]

I understand the rationale behind it, but don't you think that we could have a setting to allow urls that are not RFC compliant but widely used and accepted in all major browsers ?

For instance, if a user copy/pastes a LinkedIn url from her browser, I would expect Joi to provide a way to recognize it as valid, be it through an option.

[Marsup]

Browsers accept about anything, they just run encodeURI on it before use but show you the decoded version. Using both Chrome and Firefox, when I copy your URL, I get the encoded version in the clipboard. Do you actually have a use case where this would happen?

[mlarcher]

The linkedin url used in our example came into our subscription form. We want to validate it is a correct/usable url. Joi says it isn't even though to us it is...

[Marsup]

This sounds a lot like raw text copy-pasting, a browser wouldn't provide that. I'm not going to change the validation part (@hapi/address), but I guess joi itself could accept an option (false by default) that would apply encodeURI before attempting the validation if the convert flag is also true. Do you want to try a PR implementing that?

[mlarcher]

I'd be glad to, but I don't have enough spare time at the moment to handle that I'm afraid

[HYOSITIVE]

Can I try this issue?

[Marsup]

Sure! Be careful to target v17 branch, the main branch is currently in progress.

[HYOSITIVE]

I submitted a PR for this. Please take a look when you have a chance. Thanks!

[KaKi87]

Hi,
It would be nice not to need a parameter in the validate method call to make this work for situations where said method is called by third-party code.
Thanks

[Marsup]

Do you mean an extension? That could have some unintended consequences. Depending on how it's implemented, you can maybe force this, but I'd rather have extension providers offer that option if relevant.

[KaKi87]

What I mean is, if I pass Joi.string().uri({ encodeUri: true }), I would like it to work alone, with validate(), without needing validate({ convert: true }), which can be complicated to pass when validate is called by third-party code while I'm just passing the schema.

Thanks

[Marsup]

convert: true is the default, I'm still not sure what you mean.

[KaKi87]

Oh, I'm sorry, I wasted your time.

I was experiencing an error saying I couldn't use the encodeUri option, so I thought it was because of the convert option being required, but turns out I just didn't notice how recently this feature was added, as I only saw how long ago it was requested, so I didn't doubt whether the version I was using would already include it. Therefore, simply upgrading did the trick.

Thanks