Fail conditions documentation is unclear

[sedge]

I tried causing a before hook to fail by passing an error to its done callback, since the docs say that's one way to cause a test to fail. Apparently this has no effect on the before/after hooks.

I know the docs say tests will fail if something is passed to done, but I found it confusing and thought I would surface it.

[geek]

We can clarify this, do you know where in the readme it says this, I didn't find it?

[Marsup]

It should fail, either a bug or something wrong with your setup.

[sedge]

Ahh! I stand corrected.

I'm used to mocha's explicit reporting of the hook failing. Lab reports it as a test script error without reference to where it occurred:

In addition, despite the hook failing, the tests are still reported to have run:

Is this normal behaviour? There's no way those tests can pass if the hook fails. My test script (modified to trigger the behaviour) looks like this:

var config;

before(function(done) {
    asyncOp(function(err, value) {
      return done("This string was passed to done");

      config = value;
      done();
    });
});

experiment('[Get one file]', function() {
  experiment('[Parameter errors]', function() {
    test('user_id must be valid', function(done) {
      // Next line should throw if before hook failed,
      // failing this test:
      var opts = config.fail.invalidUserid; 

      // ...
      done();
    });

    test('project_id must be valid', function(resp) {
      // ditto
      var opts = config.fail.invalidProjectid;

       // ...
       done();
    });

    test('file_id must be valid', function(resp) {
      // And here
      var opts = config.fail.invalidFileid;

      // ...
      done();
    });
  });

  test('default', function(done) {
    // One more...
    var opts = config.success.default;

    // ...
    done();
  });
});

[sedge]

I'm aware that this now touches a couple of different potential problems. Should I split that last piece out into another issue?

[geek]

@sedge good find. When the parent experiment before function fails then the inner experiment tests shouldn't run. Marking as a bug.

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.