Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mention on README to go for 6.2.0 for node 0.10 #502

Closed
AdrieanKhisbe opened this issue Dec 22, 2015 · 7 comments
Closed

Add mention on README to go for 6.2.0 for node 0.10 #502

AdrieanKhisbe opened this issue Dec 22, 2015 · 7 comments

Comments

@AdrieanKhisbe
Copy link

New user of lab that have to support 0.10.0,
might not know to use 6.2.0.

npm install --save-dev lab, wont say anything.

Then it should be usefull to appear on the README.

(If there is an agreement, I can take care of the Fork&PR)

@AdrieanKhisbe AdrieanKhisbe changed the title Add mention on README to go for 6.2.0 Add mention on README to go for 6.2.0 for node 0.10 Dec 22, 2015
@Marsup
Copy link
Contributor

Marsup commented Dec 22, 2015

Dunno what your versions are but you should enable at least some logging level.

npm WARN engine lab@8.0.0: wanted: {"node":">=4.0.0"} (current: {"node":"0.10.41","npm":"1.4.29"})
npm WARN engine hoek@3.0.4: wanted: {"node":">=4.0.0"} (current: {"node":"0.10.41","npm":"1.4.29"})
npm WARN engine items@2.0.0: wanted: {"node":">=4.0.0"} (current: {"node":"0.10.41","npm":"1.4.29"})

@AdrieanKhisbe
Copy link
Author

You do not get then it if you work on you dev environment with node 4.

It just appeared to me after the travis build:
cf jsonicjs/jsonic#9 and https://travis-ci.org/rjrodger/jsonic/builds/98336819

@Marsup
Copy link
Contributor

Marsup commented Dec 22, 2015

I don't even know what to say to that. Devs are notorious for not reading the docs anyway, you wouldn't even have noticed, and your CI picked it up so everything is fine. If you're using a local environment that's different from your tests you'll have troubles anyway.

@AdrieanKhisbe
Copy link
Author

some hapi plugin does for a similar need: https://github.com/toymachiner62/hapi-authorization.
and it's more than welcome :)

I might be dev, I read the doc ;)
Also, it's not suprising that they don't read doc, if they do not convey useful information :p
:trollface:

more seriously, for me a readme should contains all the information needed to start using a library without any fuss

I let you decide, I won't insist. 😃

@Marsup
Copy link
Contributor

Marsup commented Dec 22, 2015

I think this should be solved elsewhere (ie. npm/npm#3662). I'm not against documenting it but as @cjihrig said, that's something we'll drag with us until the end of times.

@AdrieanKhisbe
Copy link
Author

nevermind

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants