Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab .eslintrc rules overrides local eslint rules. #504

Closed
oparamo opened this issue Dec 25, 2015 · 0 comments
Assignees
Labels
bug
Milestone

Comments

@oparamo
Copy link

@oparamo oparamo commented Dec 25, 2015

I'm having an issue when I enable linting with Lab; my local eslint config file isn't used unless I use the .eslintrc format. The problem with this is that I want to use the .eslintrc.js format instead since using .eslintrc is being depecrated by eslint.

To see this issue in action, look at this branch on my repo. Run npm test and notice that there are linting issues for rules I customized in my .eslintrc.js file.

What's happening is that Lab only checks to see if an .eslintrc file exists in the project, and if it doesn't exist then it uses Lab's default rules. So if any other config file format is being used, Lab will ignore that file and use the defaults.

I made a pull request that fixes this issue here.

@oparamo oparamo changed the title Hapi .eslintrc rules overrides local eslint rules. Lab .eslintrc rules overrides local eslint rules. Dec 26, 2015
@geek geek added the bug label Dec 27, 2015
@geek geek self-assigned this Dec 27, 2015
@geek geek added this to the 8.0.1 milestone Dec 27, 2015
@geek geek closed this Dec 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.