Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify client when heartbeat times out #240

Closed
mtharrison opened this issue Apr 18, 2018 · 2 comments
Closed

Notify client when heartbeat times out #240

mtharrison opened this issue Apr 18, 2018 · 2 comments
Labels
bug Bug or defect

Comments

@mtharrison
Copy link
Contributor

When a heartbeat timeout occurs, currently we wait for the server sent close frame and onclose event to determine that the Nes connection has disconnected, and to call onDisconnect(). However this is probably too late. Consumer should be notified as soon as we consider the connection has gone away so the consumer knows not to send any more data.
@mtharrison mtharrison added the bug Bug or defect label Apr 18, 2018
@mtharrison mtharrison mentioned this issue Apr 19, 2018
Closed
@mtharrison mtharrison changed the title onDisconnect should probably be called as soon as heartbeat times out Notify client when heartbeat times out May 2, 2018
@dominykas dominykas mentioned this issue May 3, 2018
Merged
@mtharrison
Copy link
Contributor Author

Closed #243

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Bug or defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Call onDisconnect() immediately upon heartbeat timeout hapijs/nes
1 participant
@mtharrison