Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dropping nodes in all cases, create a primary from a non-candidate #654

Closed
DimCitus opened this issue Mar 29, 2021 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request Size:M Effort Estimate: Medium user experience

Comments

@DimCitus
Copy link
Collaborator

At the moment we see in https://github.com/citusdata/pg_auto_failover/blob/master/src/monitor/node_active_protocol.c#L1044 that we refuse to remove the primary node in the monitor when we don't have a candidate for promotion. It would be better to allow for that node removal, and this requires the ability to create a primary node from existing secondary node(s).

Also, when adding a primary from secondary nodes is possible, this would allow pg_auto_failover setups with only non-candidate nodes.

In passing, we might want to improve the REPORT_LSN state to allow for the secondary node to be running, probably with fetching the current LSN and marking it as the target LSN in recovery mode while in the REPORT_LSN state.

@DimCitus
Copy link
Collaborator Author

Fixed in #661.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Size:M Effort Estimate: Medium user experience
Projects
None yet
Development

No branches or pull requests

1 participant