Chrome on android phone supports full screen #207
Conversation
that it allows fullscreen on android phones using the Chrome browser. Chrome on android has supported full screen since it's release: http://www.brighthand.com/default.asp?newsID=20141
|
Does your Android phone not automatically play the video in full screen then? In our tests, tablets played in page, so we show the button for full screen, while phones always played full screen so we hid the button. |
|
No the basic demo at http://jplayer.org/latest/demo-01-video/ plays in page for me in Chrome on a Nexus 5. It may be that the stock Webkit Android browser plays in full screen but Chrome doesn't. |
|
Just had our QA guy test on the Android browser and he also gets an in-line player as well. |
|
OK. Thanks for the info. |
|
Not sure why, but CLAhub does not like you @mattfawcett |
|
Merging this one next... But I do not have a device to verify it on. The regular expressions look ok to me. |
thepag
changed the title
|
Well this PR was a fail. Since making a copy of the jquery.jplayer.js source file in the dist folder, all the merges go with the wrong file. I do not have the git skills to fix this bullshit. Having already merged this in I wil now have to manually add in the changes to the correct file. This is a joke. I thought GitHub was supposed to sort all this crap out for us. I expect this will be the last PR accepted in this round. Dunno what I will do with the old ones... delete them i suppose. Unless someone knows the git command to sort this stuff out. |
|
Maybe @Afterster has some tips on how to fix this on my end, since he fixed his PR for aurora.js just fine. |
|
The code is now in the correct place. Sorry for letting my frustration with git show earlier. |
|
Mhh interesting issue about git / github :). |
The Chrome browser on android mobile has supported full screen since it's release. This change updates that noFullWindow regex so that it returns false if the phone is running Chrome.