Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "whitelist" and remove "whitelist-with-rate-limit" annotation #50

Closed
bedis opened this issue Aug 7, 2019 · 1 comment
Closed

Rename "whitelist" and remove "whitelist-with-rate-limit" annotation #50

bedis opened this issue Aug 7, 2019 · 1 comment
Assignees
@bedis
Labels
enhancement New feature or request

Comments

@bedis
Copy link
Contributor

bedis commented Aug 7, 2019

The name of this annotation is confusing, since it applies to the "rate limit" function only.
Would be good to rename it to rate-limit-whitelist.
In the mean time, I think the annotation whitelist-with-rate-limit is redundant and that we could apply the whitelist to the rate-limit only when rate-limit-whitelist is set.
@bedis bedis self-assigned this Aug 7, 2019
@bedis bedis added the enhancement New feature or request label Aug 7, 2019
@andy-b-84 andy-b-84 mentioned this issue Aug 7, 2019
Open
@Mo3m3n
Copy link
Contributor

Mo3m3n commented Feb 4, 2021

This was fixed at some point in 1.4
whitelist annotation will simply allow a set of IP/CIDR and block the rest at the L4 layer. There is no rate-limit involved.

@Mo3m3n Mo3m3n closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bedis bedis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bedis @Mo3m3n