Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPEG: Preserve metadata when writing CMYK #852

Closed
caixiaoquan opened this issue Oct 25, 2023 · 5 comments
Closed

JPEG: Preserve metadata when writing CMYK #852

caixiaoquan opened this issue Oct 25, 2023 · 5 comments

Comments

@caixiaoquan
Copy link

Hi Harald!
Please consider a enhancement of preserve metadata when writing CMYK.
https://stackoverflow.com/questions/77357401/why-metadata-is-ignored-when-write-a-cmyk-image?noredirect=1#comment136375922_77357401

@haraldk haraldk changed the title preserve metadata when writing CMYK JPEG: Preserve metadata when writing CMYK Oct 25, 2023
@haraldk
Copy link
Owner

haraldk commented Oct 25, 2023

Good catch, thanks for reporting!

It's a bit harder than "usual" to write metadata for CMYK files, because the SDK JPEG writer plugin we delegate to is a bit picky (and has bugs). But I made some minor changes to the writeCMYK method to allow passing some selected metadata, ie. Exif, XMP, and other APPn segments (except ICC profile) + COM (JFIF comment) markers.

Need to clean up and perhaps make some more test cases, but I think it's doable. Will try to fix soon.

@haraldk
Copy link
Owner

haraldk commented Oct 26, 2023

Please try out the latest 3.11.0-SNAPSHOT version, and see if that works for you. 😀

@caixiaoquan
Copy link
Author

Please try out the latest 3.11.0-SNAPSHOT version, and see if that works for you. 😀

OK,I will try later.Thanks!

@caixiaoquan
Copy link
Author

Hi HaraldK! After upgrading to 3.11.0-SNAPSHOT, my difficulties were resolved. By the way, when is version 3.11.0 scheduled to be released?

@haraldk
Copy link
Owner

haraldk commented Oct 26, 2023

Thanks for testing and confirming the fix! 👍🏻

There's currently no fixed release schedule, but I hope to create a 3.10.1 release with this fix back-ported some time soon.

@haraldk haraldk closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants