Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twelvemonkeys Servlet should support Jakarta #896

Closed
jreed-cartago opened this issue Jan 29, 2024 · 6 comments
Closed

Twelvemonkeys Servlet should support Jakarta #896

jreed-cartago opened this issue Jan 29, 2024 · 6 comments

Comments

@jreed-cartago
Copy link

We are currently upgrading our web application to use Java 17 and jakarta based packaging. We do actively use the twelvemonkeys libraries for extending the ImageIO functionality. In this case we expose the twelvemonkeys servlet project to start the integration at webservice startup. However this is no longer compatible since we are upgrading to jakarta.

We would like to have the class com.twelvemonkeys.servlet.image.IIOProviderContextListener upgraded to support jakarta.servlet.*

Since twelvemonkeys is rather vital for us to deal with the lack of support in the ImageIO, the only option would be to create a fork of the project and make the changes ourselves, naturally offering a Pull Request to merge into the main project.

@jreed-cartago jreed-cartago changed the title Twelvemonkeys Servlet does not support Jakarta Twelvemonkeys Servlet should support Jakarta Jan 29, 2024
@AndrewG10i
Copy link
Sponsor

AndrewG10i commented Jan 29, 2024

Just import it with classifier:

<dependency>
  <groupId>com.twelvemonkeys.servlet</groupId>
  <artifactId>servlet</artifactId>
  <version>${twelvemonkeys.version}</version>
  <classifier>jakarta</classifier>
</dependency>

@jreed-cartago
Copy link
Author

@AndrewG10i Thanks for the quick reply. I didn't find any information about a jakarta branch being available.

@haraldk
Copy link
Owner

haraldk commented Jan 29, 2024

Thanks @AndrewG10i! Yes, that is the correct way.

It is mentioned in the readme but could possibly be more clear... I'm open for a PR improving the readme. 😀

@haraldk
Copy link
Owner

haraldk commented Jan 30, 2024

Closing this for now. 😀

@haraldk haraldk closed this as completed Jan 30, 2024
@haraldk
Copy link
Owner

haraldk commented Jan 30, 2024

Added a short section here but feel free to improve on it.

@jreed-cartago
Copy link
Author

Thanks as soon as I get a breather from this upgrade I'll see if there's anything I can add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants