Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Command: <RESPAWN> #138

Open
Bendzsike opened this issue May 1, 2023 · 7 comments
Open

Change Command: <RESPAWN> #138

Bendzsike opened this issue May 1, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@Bendzsike
Copy link

Which Command
respawn

What should it do?
Right now, if I use this command, I do respawn, as the command suggests, but I get the End Screen card, which can't be turned off, disabled, or anything, no matter what you do. You can hit Esc, you can hit anything, it will stay until you press the Continue button, and that will end the "run".

@Bendzsike Bendzsike added the enhancement New feature or request label May 1, 2023
@SChinchi
Copy link
Collaborator

SChinchi commented May 1, 2023

Just to be clear, this happens when you try to respawn after the last player alive has been killed. The reason for that is the game creates the EndGameReportPanel GameObject, whose UI interferes with the game. Destroying that should do the job, but I have no idea how it would affect a multiplayer game.

The question is whether the command should do that to begin with.

@Bendzsike
Copy link
Author

Yes, I figured it's because the last alive player died as well. Imo it would be perfectly fine if it either destroyed the GameObject together with respawning, or if there was a separate command for this.

@DestroyedClone
Copy link
Contributor

Wouldn't it be better to forcibly set CharacterMaster.preventGameOver to true? Removing the gameobject for the endgamereportpanel might have weirder consquences.

@Bendzsike
Copy link
Author

Yeah, that sounds great

@SChinchi
Copy link
Collaborator

SChinchi commented May 4, 2023

That sounds much better. It can be a command that toggles it, like god.

@Bendzsike
Copy link
Author

Yeah, I like that idea. Is trhere any estimate when will it get implemented, or if at all?

@SChinchi
Copy link
Collaborator

The functionality for this behavior is indirectly achieved with the buddha command. The idea being having a command that toggles preventGameOver would require it to be run before you die, just like buddha.

They have conceptual differences, such as not dying in general so your dios are not spent, or not being able to tell whether something would have killed you or legitimately left you at 1 hp. But practically if you intend to respawn after being killed, any dios are irrelevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants